Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 246 #248

Merged
merged 2 commits into from
Mar 25, 2020
Merged

Fix issue 246 #248

merged 2 commits into from
Mar 25, 2020

Conversation

innokenty
Copy link
Contributor

See #246

@innokenty
Copy link
Contributor Author

Sorry, I didn't manage to build the project locally, but it does work when I use it in our environment. Some tests needs to be changed probably, travis build doesn't show which ones sadly. Or maybe I don't understand it...

@ArthurHlt
Copy link
Member

thanks @innokenty don't worry for travis this is red by default on a PR for now, automatic test is broken on travis.
You changes doesn't break anything, it fixes things :)

@ArthurHlt ArthurHlt merged commit 034c85f into cloudfoundry-community:dev Mar 25, 2020
@innokenty
Copy link
Contributor Author

Nice!! 🎉

@innokenty innokenty deleted the issue-246-dev branch March 25, 2020 09:49
@ArthurHlt ArthurHlt mentioned this pull request Apr 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@innokenty @ArthurHlt