Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot update b/g application labels in v3 #525

Closed
sleungcy opened this issue Sep 12, 2023 · 1 comment
Closed

Cannot update b/g application labels in v3 #525

sleungcy opened this issue Sep 12, 2023 · 1 comment

Comments

@sleungcy
Copy link
Contributor

sleungcy commented Sep 12, 2023

We are unable to modify the application labels since introduction of v3.

_ = metadataUpdate(appResp.App.GUID, appMetadata, s.rawClient, metadata)

The code here copies the labels from the venerable app over to the new version of the app.. this prevents the application from updating to new labels when the labels are changed.

I believe this code was copied over from the v2 code from here:
https://github.com/cloudfoundry-community/terraform-provider-cloudfoundry/blob/main/cloudfoundry/managers/appdeployers/bluegreenv2_strategy.go#L104

Basing on the comment:

// copy metadata from original app since they do
// not carry over in the ccv2.Application data structure

This code would not be needed in bluegreen_strategy_v3.go, as we already migrated over to ccv3.Application.

@sleungcy
Copy link
Contributor Author

changes proposed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant