This repository has been archived by the owner on Jan 21, 2022. It is now read-only.
Splits ContainerMetrics and ContainerInfo into two separate structs #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously GetInfo returned both the container info as well as the metrics. metrics turned out to be expensive, this change is separating them. It also removes some unused ContainerInfo fields, e.g. HostIpAddress. Some of those fields required looping through the network interfaces and figuring out the ip address. although we could possibly cache the information it seems unecessary to do the effort given that the containerizer doesn't use them. [#105015120] Signed-off-by: Micah Young <myoung@pivotal.io>
|
@brannon what do you think ? |
|
There have been some other major changes that we would like your input on when you have chance, 33c6803. |
jvshahid
added a commit
that referenced
this pull request
Oct 6, 2015
…rics Splits ContainerMetrics and ContainerInfo into two separate structs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously GetInfo returned both the container info as well as the metrics.
metrics turned out to be expensive, this change is separating them. It also
removes some unused ContainerInfo fields, e.g. HostIpAddress. Some of those
fields required looping through the network interfaces and figuring out
the ip address. although we could possibly cache the information it seems
unecessary to do the effort given that the containerizer doesn't use them.
[#105015120]
Signed-off-by: Micah Young myoung@pivotal.io