Support Bionic stemcell

[FlorianNachtigall]

Hi all,

we tried to compile the backup-and-restore-sdk release for Ubuntu Bionic and ran into the following error:

'TLSv1_client_method' is deprecated [-Wdeprecated-declarations]
                                          TLSv1_client_method() :
                                          ^~~~~~~~~~~~~~~~~~~
In file included from /usr/include/openssl/e_os2.h:13:0,
                 from /usr/include/openssl/ssl.h:15,

It seems that the openssl version of Bionic is not compatible with mysql 5.6 (tested with 1.18.3 & 1.18.5).

Thanks!
cc @StefanWutz

---

To reproduce:

bosh -e bosh export-release -d compilation-workspace backup-and-restore-sdk/1.18.3 ubuntu-bionic/0.18

name: compilation-workspace

releases:
- name: backup-and-restore-sdk
  version: "1.18.3"

stemcells:
- alias: default
  os: ubuntu-bionic
  version: latest

instance_groups: []

update:
  canaries: 1
  max_in_flight: 1
  canary_watch_time: 1000-90000
  update_watch_time: 1000-90000
~

---

Full error log:

Task XXXX | 13:52:48 | Compiling packages: database-backup-restorer-mysql-5.6/1510ee0c2b36d03063e9d34cf4e82a30666cb0787802c2b80ec79d363cfec7a4 (00:06:01)
                      L Error: Action Failed get_task: Task e421a611-8de3-422d-505f-16aff1c25546 result: Compiling package database-backup-restorer-mysql-5.6: Running packaging script: Running packaging script: Command exited with 2; Truncated stdout: -- Looking for timeradd - not found
[...]
-- Build files have been written to: /var/vcap/data/compile/database-backup-restorer-mysql-5.6/mysql-5.6.45/bld
/var/vcap/data/compile/database-backup-restorer-mysql-5.6/mysql-5.6.45/cmd-line-utils/libedit/terminal.c: In function 'terminal_alloc':
/var/vcap/data/compile/database-backup-restorer-mysql-5.6/mysql-5.6.45/cmd-line-utils/libedit/terminal.c:366:28: warning: comparison between pointer and zero character constant [-Wpointer-compare]
   if (*tmp != NULL && *tmp != '\0' && *tmp != *str) {
                            ^~
/var/vcap/data/compile/database-backup-restorer-mysql-5.6/mysql-5.6.45/cmd-line-utils/libedit/terminal.c:366:23: note: did you mean to dereference the pointer?
   if (*tmp != NULL && *tmp != '\0' && *tmp != *str) {
                       ^
/var/vcap/data/compile/database-backup-restorer-mysql-5.6/mysql-5.6.45/vio/vio.c: In function 'vio_end':
/var/vcap/data/compile/database-backup-restorer-mysql-5.6/mysql-5.6.45/vio/vio.c:387:3: warning: 'ERR_remove_state' is deprecated [-Wdeprecated-declarations]
   ERR_remove_state(0);
   ^~~~~~~~~~~~~~~~
In file included from /usr/include/openssl/e_os2.h:13:0,
                 from /usr/include/openssl/ssl.h:15,
                 from /var/vcap/data/compile/database-backup-restorer-mysql-5.6/mysql-5.6.45/include/violite.h:143,
                 from /var/vcap/data/compile/database-backup-restorer-mysql-5.6/mysql-5.6.45/vio/vio_priv.h:26,
                 from /var/vcap/data/compile/database-backup-restorer-mysql-5.6/mysql-5.6.45/vio/vio.c:23:
/usr/include/openssl/err.h:260:1: note: declared here
 DEPRECATEDIN_1_0_0(void ERR_remove_state(unsigned long pid))
 ^
/var/vcap/data/compile/database-backup-restorer-mysql-5.6/mysql-5.6.45/vio/viosslfactories.c: In function 'get_dh2048':
/var/vcap/data/compile/database-backup-restorer-mysql-5.6/mysql-5.6.45/vio/viosslfactories.c:71:7: error: dereferencing pointer to incomplete type 'DH {aka struct dh_st}'
     dh->p=BN_bin2bn(dh2048_p,sizeof(dh2048_p),NULL);
       ^~
/var/vcap/data/compile/database-backup-restorer-mysql-5.6/mysql-5.6.45/vio/viosslfactories.c: In function 'new_VioSSLFd':
/var/vcap/data/compile/database-backup-restorer-mysql-5.6/mysql-5.6.45/vio/viosslfactories.c:233:42: warning: 'TLSv1_client_method' is deprecated [-Wdeprecated-declarations]
                                          TLSv1_client_method() :
                                          ^~~~~~~~~~~~~~~~~~~
In file included from /usr/include/openssl/e_os2.h:13:0,
                 from /usr/include/openssl/ssl.h:15,
                 from /var/vcap/data/compile/database-backup-restorer-mysql-5.6/mysql-5.6.45/include/violite.h:143,
                 from /var/vcap/data/compile/database-backup-restorer-mysql-5.6/mysql-5.6.45/vio/vio_priv.h:26,
                 from /var/vcap/data/compile/database-backup-restorer-mysql-5.6/mysql-5.6.45/vio/viosslfactories.c:16:
/usr/include/openssl/ssl.h:1854:1: note: declared here
 DEPRECATEDIN_1_1_0(__owur const SSL_METHOD *TLSv1_client_method(void))
 ^
/var/vcap/data/compile/database-backup-restorer-mysql-5.6/mysql-5.6.45/vio/viosslfactories.c:234:42: warning: 'TLSv1_server_method' is deprecated [-Wdeprecated-declarations]
                                          TLSv1_server_method())))
                                          ^~~~~~~~~~~~~~~~~~~
In file included from /usr/include/openssl/e_os2.h:13:0,
                 from /usr/include/openssl/ssl.h:15,
                 from /var/vcap/data/compile/database-backup-restorer-mysql-5.6/mysql-5.6.45/include/violite.h:143,
                 from /var/vcap/data/compile/database-backup-restorer-mysql-5.6/mysql-5.6.45/vio/vio_priv.h:26,
                 from /var/vcap/data/compile/database-backup-restorer-mysql-5.6/mysql-5.6.45/vio/viosslfactories.c:16:
/usr/include/openssl/ssl.h:1853:1: note: declared here
 DEPRECATEDIN_1_1_0(__owur const SSL_METHOD *TLSv1_server_method(void))
 ^
make[2]: *** [vio/CMakeFiles/vio.dir/viosslfactories.c.o] Error 1
make[1]: *** [vio/CMakeFiles/vio.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [all] Error 2
, Stderr: + MYSQL_VERSION=5.6.45
++ pwd
+ MY_DIR=/var/vcap/data/compile/database-backup-restorer-mysql-5.6
+ tar xzf mysql/mysql-5.6.45.tar.gz
+ set -e
+ cd mysql-5.6.45
+ mkdir bld
+ cd bld
+ cmake .. -DCMAKE_INSTALL_PREFIX=/var/vcap/packages/database-backup-restorer-mysql-5.6 -DWITHOUT_SERVER=ON -DWITH_SSL=system -DWITH_WSREP=ON -DWITH_INNODB_DISALLOW_WRITES=1 -DWITH_PCRE=bundled

[cf-gitbot]

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

[gbandres98]

Hi, PR #140 bumps mysql 5.6 to the latest version, which supports a more recent release of TLS and fixes this error. Thanks for the heads up!