Enhancement: Support for Accelerator in Cloud Properties

[victorfong]

I have come across an use case that require GPU on some of the Bosh deployed VM in GCP. I'm proposing that the manifest would look something like this:

resource_pools:
- name: common
  network: private
  stemcell:
    name: bosh-google-kvm-ubuntu-trusty-go_agent
    version: latest
  cloud_properties:
    zone: us-east1-d
    region: us-east1
    machine_type: n1-standard-2
    root_disk_size_gb: 20
    root_disk_type: pd-standard
    accelerator:
      type: nvidia-tesla-k80
      count: 1

Behavior will not change if user does not fill out the accelerator properties. During VM creation, we'll pass in something like --accelerator type=nvidia-tesla-k80,count=1.

If it's ok with the community, my team can submit a PR for this enhancement. In the mean time, please let me know if there is any question or concern.

Thanks,
Victor

[cppforlife]

@victorfong i think this is a good addition.

[evandbrown]

@victorfong Sounds great, and I like the proposed format of cloud_properties. Let me know if you have any questions while working on the PR. Thank you!

[kaleo211]

@evandbrown Hi Evan! The CPI level code is pretty much done. The only issue we have is about the Google API version. Only the v0.beta supports creation of Instance with Accelerator (GPU). The one we are using now is v1.
I saw you guys already put beta version in code. I don't know whether it's OK to use beta version for the whole google/instance_service/google_instance_service_create.go or might use JSON to transfer the structs between versions to reuse private functions.

[victorfong]

@cppforlife @evandbrown Hi. Like @kaleo211 mentioned, it looks like only the v0.beta version of Google API supports Accelerator. Would you like us to hold off on the pull release until Google API officially supports Accelerator? Thanks.

[johnsonj]

Hey @kaleo211 @victorfong - sorry this slipped through the cracks. Is this something you're still interested in? Happy to work with you to get it in.