Tests use proper custom backend #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey zaksoup! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
- ...instead of normal backend, which fails
- include formatting changes (i.e. indents)
fixes:
```
executes the VM lifecycle with a region backend service [It]
/Users/pivotal/workspace/bosh-google-cpi-release/src/bosh-google-cpi/integration/vm_test.go:733
Expected
<*dispatcher.ResponseError | 0xc4203ab170>: {
Type: "Bosh::Clouds::VMCreationFailed",
Message: "VM failed to create: Failed to add instance \"https://www.googleapis.com/compute/beta/projects/cf-bosh-cpi-dev/zones/us-central1-a/instances/vm-06e26e99-18d9-451a-5806-a946c586c111\" to Backend Service \"cfintegration\"'s instance group named \"cfintegration-ilb\": Failed to add Google Instance 'vm-06e26e99-18d9-451a-5806-a946c586c111' to Google Instance Group 'cfintegration-ilb': googleapi: Error 400: Resource 'projects/cf-bosh-cpi-dev/zones/us-central1-a/instances/vm-06e26e99-18d9-451a-5806-a946c586c111' is expected to be in the network 'projects/cf-bosh-cpi-dev/global/networks/cfintegration' but is in the network 'projects/cf-bosh-cpi-dev/global/networks/cfintegration-custom'., wrongNetwork",
CanRetry: true,
}
to be nil
/Users/pivotal/workspace/bosh-google-cpi-release/src/bosh-google-cpi/integration/assertions.go:27
```
[#145703989](https://www.pivotaltracker.com/story/show/145703989)
Signed-off-by: Brian Cunnie <bcunnie@pivotal.io>
Signed-off-by: Zak Auerbach <zauerbach@pivotal.io>
johnsonj
approved these changes
May 22, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix to #182