UPDATE Import certs without ca flag #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/174207532 The labels on this github issue will be updated when the story is started. |
This was referenced Aug 6, 2020
adobley
suggested changes
Aug 6, 2020
HappyTobi
force-pushed
the
import_cert_without_cat
branch
from
04cf68c
to
e9c551b
Compare
bruce-ricard
approved these changes
Aug 7, 2020
There was a problem hiding this comment.
Fantastic. Thank you @HappyTobi !
Thank you again for the docs and formatting fixes, and for splitting them in different commits. We love it.
We'll merge this PR when the Credhub PR is ready.
@peterhaochen47 and I
bruce-ricard
added
blocked-on-credhub-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I just added the test for the latest PR / Change at CredHub plus a small README Update
With the new test, it's possible to validate that the import of a self signed certificate (without a "valid" ca was working)
CredHub PR: #150
CredHub Issue: #134
Other PR (that will be rejected but good to know) #139
Kind regards
Tobi