Skip to content
This repository has been archived by the owner on Jan 25, 2022. It is now read-only.

Add CurrentMemoryLimit to IContainer #21

Merged
merged 1 commit into from Apr 15, 2015

Conversation

benmoss
Copy link

@benmoss benmoss commented Apr 14, 2015

Hi @brannon

We're working on adding the ability to constrain memory (https://www.pivotaltracker.com/story/show/92180278) and need the ability to get the current memory limit from the job object.

We left the ContainerStub implementation throwing a NotImplementedException since we weren't sure what that class is for and weren't sure if it was relevant for us.

Ben & Dave

@cfdreddbot
Copy link

Hey benmoss!

Thanks for submitting this pull request!

All pull request authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

@brannon
Copy link
Contributor

brannon commented Apr 14, 2015

@benmoss it looks like you need to publicize your cloudfoundry membership in GitHub, so that cfdreddbot recognizes your CLA.

I'll take a look at the PR. It's probably safe to leave the ContainerStub method as-is. I have an outstanding PR as well that should obsolete ContainerStub.

I was planning to merge my PR today, so we should coordinate these.

@benmoss
Copy link
Author

benmoss commented Apr 14, 2015

Membership has been publicized. We're happy to chat whenever you are, you can reach us on Slack via Dave Goddard's account.

@brannon
Copy link
Contributor

brannon commented Apr 15, 2015

@benmoss @dgoddard I'll go ahead and merge this and then merge my PR afterward. My PR is so large, I don't want to block you guys if it causes problems.

brannon added a commit that referenced this pull request Apr 15, 2015
@brannon brannon merged commit 83b83dd into extractContainerLib Apr 15, 2015
@brannon brannon deleted the addCurrentMemoryLimit branch April 16, 2015 16:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants