Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compromising information in client message #115

Closed
ashishjain14 opened this issue Dec 5, 2017 · 2 comments
Closed

Compromising information in client message #115

ashishjain14 opened this issue Dec 5, 2017 · 2 comments

Comments

@ashishjain14
Copy link
Contributor

When trying to create a service instance, without having an entitlement, the message displayed in the client displays information that appears to be a security risk:
The service broker rejected the request to https://:9293/cf/v2/service_instances/691f1431-6fcd-4cbd-a3fb-d1510f0e675c?accepts_incomplete=true. Status Code: 403 Forbidden, Body:
{"status":403,"message":"Not entitled to create service instance"}

Currently the error message displays The IP:port and full path of the service. This seems to be coming from https://github.com/cloudfoundry/cloud_controller_ng/blob/173954d8ed2d2b9624d074ba2b277f7bd47c8432/lib/services/service_brokers/v2/errors/service_broker_request_rejected.rb#L15

How can this information be masked on failure?

@ashishjain14
Copy link
Contributor Author

Opened a bug in capi cloudfoundry/cloud_controller_ng#1025

@pivotal-marcela-campo
Copy link
Member

pivotal-marcela-campo commented Mar 9, 2022

The Bug in CAPI has been closed as won't fix as they don't consider it to be a security concern.
Will proceed to close this bug if there are no objections.
@cloudfoundry-incubator/wg-service-management-service-fabrik-approvers @cloudfoundry-incubator/service-fabrik

@anoopjb anoopjb closed this as completed Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants