Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need better instructions on go mod vendor before creating the release #279

Closed
garethjevans opened this issue Jul 20, 2021 · 2 comments
Closed
Labels

Comments

@garethjevans
Copy link
Contributor

Currently, we have set GOPROXY=off in the packaging scripts for the golang packages which stop go build from trying to access the internet when building each binary, but... this required go mod download && go mod vendor to be run before creating the bosh release. This will be a manual step that needs to be run before we have a pipeline that creates a release automatically.

We need to document this somewhere.

@KevinJCross
Copy link
Contributor

we should have make target make release to generate a new release. This should be added to our documentation.

@silvestre
Copy link
Member

We already document that a call to scripts/update is necessary: https://github.com/cloudfoundry/app-autoscaler-release/blob/061aeaa7e97a55e813cc9b3dcc8453b4542e8905/README.md#bosh-lite-deployment

We will however check how to make this clearer in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants