Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space application supporter apps permissions #2282

Merged
merged 6 commits into from May 19, 2021

Conversation

monamohebbi
Copy link
Contributor

Adresses #2209

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

weymanf and others added 6 commits May 12, 2021 21:58
space_application_supporter

* #2210

Co-authored-by: Weyman Fung <weymanf@vmware.com>
Co-authored-by: Mona Mohebbi <mmohebbi@pivotal.io>
Co-authored-by: Belinda Liu <bliu@pivotal.io>
Co-authored-by: Matthew Kocher <mkocher@pivotal.io>
`GET /v3/apps/:guid/droplets/current`
`GET /v3/apps/:guid/relationships/current_droplet`

Github issue: #2209

Co-authored-by: Belinda Liu <bliu@pivotal.io>
Co-authored-by: Matthew Kocher <mkocher@pivotal.io>
- This is now covered in a request spec that was introduced in the
previous commit

Co-authored-by: Matthew Kocher <mkocher@pivotal.io>
Co-authored-by: Belinda Liu <bliu@pivotal.io>
Co-authored-by: Mona Mohebbi <mmohebbi@pivotal.io>
`GET /v3/apps/:guid/permissions`

- also remove redundant tests for the apps controller
- fix typo in builds controller

Co-authored-by: Belinda Liu <bliu@pivotal.io>
Co-authored-by: Weyman Fung <weymanf@vmware.com>
Co-authored-by: Mona Mohebbi <mmohebbi@pivotal.io>
Co-authored-by: Merric de Launey <mdelauney@pivotal.io>
Co-authored-by: Mona Mohebbi <mmohebbi@pivotal.io>
Co-authored-by: Belinda Liu <bliu@pivotal.io>
@monamohebbi monamohebbi linked an issue May 18, 2021 that may be closed by this pull request
6 tasks
@sweinstein22 sweinstein22 merged commit 8abb2d0 into main May 19, 2021
@sweinstein22 sweinstein22 deleted the space_application_supporter_apps_permissions branch May 19, 2021 20:49
@mkocher mkocher added the space-application-supporter https://github.com/cloudfoundry/cfar-proposals/issues/22 label Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
space-application-supporter https://github.com/cloudfoundry/cfar-proposals/issues/22
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Space Application Supporter can access specific app GET endpoints
7 participants