Allows space supporter to access GET v3/service_route_bindings #2426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/v3/service_route_bindings Closes #2422 Authored-by: Galen Hammond <galenh@vmware.com>
sweinstein22
added
the
space-application-supporter
There was a problem hiding this comment.
Acceptance
Behavior Check
Ran cf curl against v3/service_route_bindings as both a space supporter and space developer. Manually confirmed output looks correct and checked for a diff:
$ diff space-supporter-service-route-bindings space-dev-service-route-bindings
Code Check
Looks good, pretty minimal changes that use the established patterns for this work
sweinstein22
suggested changes
Jul 20, 2021
Authored-by: Galen Hammond <galenh@vmware.com>
sweinstein22
approved these changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows space supporter access to service route binding list endpoint
Closes #2422
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests