This repository has been archived by the owner on Jan 21, 2022. It is now read-only.
Expose available_disk in stager advertisement #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: http://www.pivotaltracker.com/story/show/68994200. This repo is managed by the 'Runtime' team. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloud controller already makes sure it only attempts to start (as opposed to stage) on DEAs with enough disk, but it doesn't currently check whether stagers have enough disk before staging. This results in errors when a CC attempts to start on a DEA that's out of disk, which then refuses the request. This change exposes available_disk in the staging advertisement so that CC can know if a staging request is going to fail before it sends it to the DEA (exactly as already happens for start requests).