Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EXECUTOR/REP PR REVIEW]: disable log rate limit metrics for tasks #821

Closed
mkocher opened this issue Sep 16, 2023 · 2 comments
Closed

[EXECUTOR/REP PR REVIEW]: disable log rate limit metrics for tasks #821

mkocher opened this issue Sep 16, 2023 · 2 comments

Comments

@mkocher
Copy link
Member

mkocher commented Sep 16, 2023

We noticed that staging containers were generating log rate metrics but not other metrics, and those log rate metrics didn't have the correct tags.

These two PRs make it so tasks no longer emit log rate metrics.
@MarcPaquette
Copy link
Contributor

These two issues have been merged. We are expecting the autobumps to automatically roll in the changes into diego-release.

@mkocher Is there a rush to get this into the release?

@mkocher
Copy link
Member Author

mkocher commented Oct 12, 2023

no rush, this has been a minor bug for a while

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mkocher @MarcPaquette @winkingturtle-vmw