Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for docker images with attestation information #833

Closed
beyhan opened this issue Oct 11, 2023 · 3 comments
Closed

Add support for docker images with attestation information #833

beyhan opened this issue Oct 11, 2023 · 3 comments

Comments

@beyhan
Copy link
Member

beyhan commented Oct 11, 2023

Summary

If you try to push the version 1.23.2 of the nginxinc/nginx-unprivileged image to CF with cf push nginx-unprivileged --docker-image nginxinc/nginx-unprivileged:1.23.2 it will work. Pushing the next version 1.23.3 fails with the error:

...
2023-10-06T09:35:25.78+0200 [STG/0] OUT Staging process started ...
2023-10-06T09:35:26.71+0200 [STG/0] ERR Staging process failed: Exit trace for group:
2023-10-06T09:35:26.71+0200 [STG/0] ERR builder exited with error: failed to fetch metadata from [nginxinc/nginx-unprivileged] with tag [latest] and insecure registries [] due to unsupported schema version 2
2023-10-06T09:35:26.72+0200 [STG/0] OUT Exit status 2
...

Looking into the image manifest with docker manifest inspect --verbose nginxinc/nginx-unprivileged:1.23.3 shows that it is the first version where they attach image attestation information to the manifest. It looks like Diego can’t deal with this. This is definitely an issue because more and more images will start to add such information.

Diego repo

If the feature request is associated with a sub-component of diego-release add the name of the repo here, else, leave blank.

Describe alternatives you've considered (optional)

An alternative solution would be to produce docker images without build attestation information but the trend is to have more secure supply chains. That is why this isn't really an alternative.

Additional Text Output, Screenshots, or contextual information (optional)

Diego Slack channel discussion.

@ericgravelle-energir
Copy link

I think my own issue here: Error handling docker v2 schema is related.

@winkingturtle-vmw
Copy link
Contributor

This issue has been fixed as of Diego v2.91.0.

@beyhan
Copy link
Member Author

beyhan commented Jan 30, 2024

Thanks @winkingturtle-vmw for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants