Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PCF specific if clauses #87

Closed
cloudlena opened this issue Jul 24, 2017 · 1 comment
Closed

Remove PCF specific if clauses #87

cloudlena opened this issue Jul 24, 2017 · 1 comment

Comments

@cloudlena
Copy link
Contributor

Some of the files contain PCF specific if clauses to display partials. An example is https://github.com/cloudfoundry/docs-cf-admin/blob/master/securing-traffic.html.md.erb#L117.

I think that OSS documentation shouldn't contain anything which is specific to one provider. In my case, Bookbinder always wants to use the PCF partial instead of the CF one because my product is not named "CF". Is there any way of turning these if clauses around so that it defaults to using the OSS version and not the PCF version? I've had to create the partials as the files required by the PCF version and fill them with the OSS version which isn't nice...

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/149390381

The labels on this github issue will be updated when the story is started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants