Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading documentation #383

Closed
SvetlinZarev opened this issue Feb 21, 2017 · 1 comment
Closed

Misleading documentation #383

SvetlinZarev opened this issue Feb 21, 2017 · 1 comment
Assignees
Milestone

Comments

@SvetlinZarev
Copy link

SvetlinZarev commented Feb 21, 2017

Hello,

The components.yml file and the docs for Oracle JRE imply that one has to fork the buildpack in order to change the default JRE and it's configuration (i.e. repository location). Yet, according to the Zulu JRE docs, it's possible to achieve the same using the JBP_CONFIG_COMPONENTS and JBP_CONFIG_[ORACLE|OPEN_JDK]_JRE env variable.

Is this gap in the documentation intentional and that comment in components.yml outdated ?

Best regards,
Svetlin

@nebhale
Copy link
Member

nebhale commented Feb 21, 2017

Just outdated.

@nebhale nebhale self-assigned this Feb 21, 2017
@nebhale nebhale modified the milestones: v4.0, v3.14 Feb 21, 2017
@nebhale nebhale closed this as completed in d5d58c6 Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants