no_proxy hosts are not included.

[mohanbabubb]

On the script,

java-buildpack/lib/java_buildpack/util/cache/download_cache.rb

Lines 269 to 276 in 8aa5c04

	proxy_uri = if secure?(uri)
	URI.parse(ENV['https_proxy'] || ENV['HTTPS_PROXY'] || '')
	else
	URI.parse(ENV['http_proxy'] || ENV['HTTP_PROXY'] || '')
	end
	@logger.debug { "Proxy: #{proxy_uri.host}, #{proxy_uri.port}, #{proxy_uri.user}, #{proxy_uri.password}" }
	Net::HTTP::Proxy(proxy_uri.host, proxy_uri.port, proxy_uri.user, proxy_uri.password)

, if have environment variable for no_proxy for some hosts/localhost/local ip's which need to be skipped through proxy but the script had no option to evaluate the localhost and no_proxy environment variable.
Scenario:
If i host a local repo server and run the rake task to use the local repo server for build, its failing.
I think it would be good to add some condition to consider no_proxy during run.

[gberche-orange]

@nebhale I ran into this issue, and associated commit 834c978 as I was looking for example syntax of the NO_PROXY variable.

I had a hard time understanding the spec which currently says the following but actually asserts the proxy is used.

does not use proxy if host in NO_PROXY
does not use proxy if host in no_proxy

I wonder whether you indeed meant:

uses proxy if host is not in NO_PROXY
uses proxy if host is not in no_proxy

and missed to implement the following cases ?

does not use proxy if host in NO_PROXY
does not use proxy if host in no_proxy