Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: As a Korifi app developer I want to see the MEMORY_LIMIT environment variable in my app containers #3081

Closed
danail-branekov opened this issue Jan 25, 2024 · 2 comments
Labels
good first issue Good for newcomers mta support the MTA controller

Comments

@danail-branekov
Copy link
Member

danail-branekov commented Jan 25, 2024

Background

The MEMORY_LIMIT environment variable is a standard Cloud Foundry one that hints applications on the memory limit they can use before getting restarted.

As a Korifi app developer
I want to communicate the memory limit to my app
So that I can implement the app not to exceed the limit and eventually get restarted

Acceptance Criteria

GIVEN a standard Korifi installation
WHEN I cf push dorifi -p ~/workspace/trinity/korifi/tests/assets/dorifi -m 2345M
THEN I see the MEMORY_LIMIT set to 2345M in my app environment (by e.g. running curl -k https://dorifi.apps.172.17.0.1.nip.io/env.json | jq .MEMORY_LIMIT)

@danail-branekov danail-branekov changed the title Support the MEMORY_LIMIT env variable As a Korifi app developer I want to see the MEMORY_LIMIT environment variable in my app containers Jan 25, 2024
@danail-branekov danail-branekov changed the title As a Korifi app developer I want to see the MEMORY_LIMIT environment variable in my app containers [Feature]: As a Korifi app developer I want to see the MEMORY_LIMIT environment variable in my app containers Jan 25, 2024
@danail-branekov danail-branekov added the mta support the MTA controller label Jan 25, 2024
@danail-branekov danail-branekov added the good first issue Good for newcomers label Feb 19, 2024
@marsteg
Copy link
Contributor

marsteg commented Mar 13, 2024

opened PR for this issue:#3191

@marsteg
Copy link
Contributor

marsteg commented Mar 28, 2024

I think this could be closed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers mta support the MTA controller
Projects
Status: Done
Development

No branches or pull requests

2 participants