defaultGenericLogger supports debug flag

Signed-off-by: Joseph Rodriguez <jrodriguez@pivotallabs.com>
cloudfoundry-attic · Aug 12, 2014 · 7e6ea91 · 7e6ea91
1 parent 901c746
commit 7e6ea91
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 12 deletions.
diff --git a/appservice/app_service_test.go b/appservice/app_service_test.go
@@ -1,9 +1,9 @@
 package appservice_test
 
 import (
+	. "github.com/cloudfoundry/loggregatorlib/appservice"
 	. "github.com/onsi/ginkgo"
 	. "github.com/onsi/gomega"
-	. "github.com/cloudfoundry/loggregatorlib/appservice"
 )
 
 var _ = Describe("AppService", func() {

diff --git a/cfcomponent/generic_logger/generic_logger.go b/cfcomponent/generic_logger/generic_logger.go
@@ -8,23 +8,28 @@ type GenericLogger interface {
 	Fatalf(string, ...interface{})
 	Errorf(string, ...interface{})
 	Debugf(string, ...interface{})
-
 }
 
-type defaultGenericLogger struct{}
+type defaultGenericLogger struct {
+	debug bool
+}
 
-func NewDefaultGenericLogger() GenericLogger {
-	return defaultGenericLogger{}
+func NewDefaultGenericLogger(debug bool) GenericLogger {
+	return defaultGenericLogger{
+		debug: debug,
+	}
 }
 
-func (defaultGenericLogger) Fatalf(format string, args... interface{}) {
+func (defaultGenericLogger) Fatalf(format string, args ...interface{}) {
 	log.Fatalf(format, args...)
 }
 
-func (defaultGenericLogger) Errorf(format string, args... interface{}) {
-	log.Printf("ERROR: " + format, args...)
+func (defaultGenericLogger) Errorf(format string, args ...interface{}) {
+	log.Printf("ERROR: "+format, args...)
 }
 
-func (defaultGenericLogger) Debugf(format string, args... interface{}) {
-	log.Printf("DEBUG: " + format, args...)
+func (l defaultGenericLogger) Debugf(format string, args ...interface{}) {
+	if l.debug {
+		log.Printf("DEBUG: "+format, args...)
+	}
 }
diff --git a/loggregatorclient/loggregator_client.go b/loggregatorclient/loggregator_client.go
@@ -1,8 +1,8 @@
 package loggregatorclient
 
 import (
-	"github.com/cloudfoundry/loggregatorlib/cfcomponent/instrumentation"
 	"github.com/cloudfoundry/loggregatorlib/cfcomponent/generic_logger"
+	"github.com/cloudfoundry/loggregatorlib/cfcomponent/instrumentation"
 	"net"
 	"sync/atomic"
 )

diff --git a/store/cache/app_service_cache_test.go b/store/cache/app_service_cache_test.go
@@ -1,9 +1,9 @@
 package cache_test
 
 import (
+	. "github.com/cloudfoundry/loggregatorlib/store/cache"
 	. "github.com/onsi/ginkgo"
 	. "github.com/onsi/gomega"
-	. "github.com/cloudfoundry/loggregatorlib/store/cache"
 
 	"github.com/cloudfoundry/loggregatorlib/appservice"
 )