Skip to content
This repository has been archived by the owner on May 8, 2020. It is now read-only.

README is incomprehensible #3

Closed
dsyer opened this issue Oct 14, 2018 · 3 comments
Closed

README is incomprehensible #3

dsyer opened this issue Oct 14, 2018 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@dsyer
Copy link

dsyer commented Oct 14, 2018

I found out by trial and error that if I want to use Java I can pass a build plan like this in stdout from a detect in another buildpack:

[openjdk-jdk]
  provider = ""
  version = "1.*"

I don't really know how or why that works. It would be kind of useful to get more detail and the README seems like an excellent place to start.

@nebhale nebhale assigned nebhale and twoseat and unassigned nebhale Oct 15, 2018
@nebhale nebhale added the enhancement New feature or request label Oct 15, 2018
@nebhale
Copy link
Member

nebhale commented Oct 15, 2018

@dsyer The README can obviously use some improvement, but what about the Build section didn't indicate to you that adding [openjdk-jdk] to the build plan would "Contributes a JDK to a cache layer". Just trying to determine why trial and error was necessary when that doc was in place.

@dsyer
Copy link
Author

dsyer commented Oct 15, 2018

It doesn't say that [openjdk-jdk] is a line in the build plan (aka stdin). Also doesn't mention either "provider" or "version" or how they might need to be matched.

It's just not very friendly to someone who doesn't know the guts of buildpacks. Example

Contributes JAVA_HOME configured to a cache layer named the same as the key

  • "Contributes" how? I assume it's an env var. Is it consumable by other buildpacks?
  • "Configured to" do something or to be something? And what?
  • What is "named the same as the key"?
  • What's "the key"?

Examples are really useful for this kind of thing.

@nebhale
Copy link
Member

nebhale commented Oct 15, 2018

Sounds good. We'll roll that input back into the docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants