Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strategy for maintaining Fabricator fork (upstream/downstream changes) #66

Closed
tylersticka opened this issue Aug 4, 2015 · 11 comments
Closed

Comments

@tylersticka
Copy link
Member

Creating an issue to track something @lyzadanger and I discussed. There have been a number of adjustments to this repo that puts it quite a ways ahead of cloudfour/fabricator. We should probably have a plan for keeping these in better sync in the future.

@erikjung
Copy link
Contributor

erikjung commented Sep 4, 2015

Personally, I think we should un-fork and just keep fabricator-assemble updated.

@erikjung
Copy link
Contributor

erikjung commented Oct 2, 2015

Bumping this so we can discuss and decide on Monday.

@lyzadanger
Copy link

Hi, @erikjung! First: Not 100% certain what the context is here (DI scoping, moving ahead on this project specifically), so apologies if I'm barking up the wrong tree—i.e. I'm not sure if you're after strategy or logistics. As I recall, our latest (strategic) position on this is to not maintain fabricator upstream from our fabricator fork. That is, the web assets and front-end piece is now our own, but we rely on the fabricator-assemble npm module (uncustomized) for the building piece.

Perhaps, however, you are after logistics? Let me know if you know more about "un-forking" than I do—AFAIK there is no specific way to do that (various roundabout ways to accomplish it).

@erikjung
Copy link
Contributor

erikjung commented Oct 5, 2015

@lyzadanger

Not 100% certain what the context is here (DI scoping, moving ahead on this project specifically), so apologies if I'm barking up the wrong tree—i.e. I'm not sure if you're after strategy or logistics.

On Friday, I was trying to refresh my memory of this project, and saw that this issue/strategy was still seemingly undecided, so I thought maybe we could just come up with a task list or something.

Let me know if you know more about "un-forking" than I do

I do not :)

Do you believe we'll need to make an entirely new repo then?

@tylersticka
Copy link
Member Author

FYI, you can also contact GitHub and request they change your forked repository into a "standard" repository: https://help.github.com/articles/why-are-my-contributions-not-showing-up-on-my-profile/#commit-was-made-in-a-fork

@erikjung
Copy link
Contributor

erikjung commented Oct 5, 2015

@tylersticka Sounds like the way to go.

@erikjung
Copy link
Contributor

erikjung commented Oct 5, 2015

  • https://github.com/contact and find out about converting the repo
  • Convert to standard repo
  • Update README to present this tool accurately

@tylersticka
Copy link
Member Author

Oh wait, but... this repo doesn't look like a fork to me?

I mean, it has the original Fabricator's dev history, but it doesn't have the usual GH UI associated with being a "fork." As far as GH is concerned, it doesn't appear to be.

So I may not understand what we're talking about.

@erikjung
Copy link
Contributor

erikjung commented Oct 6, 2015

@tylersticka Oh yeah :(

In all this excitement, I forgot we were originally discussing https://github.com/cloudfour/fabricator

I guess we need an issue there as well. Those tasks above should apply mostly to the Fabricator repo (though we also need the README here too, bleh)

@lyzadanger
Copy link

@erikjung Hah, yes, funny. Yesterday it took me a while to find this issue because I was looking on https://github.com/cloudfour/fabricator :)

And should we rename it?

@tylersticka
Copy link
Member Author

Just stumbled across this issue and it looks hilariously (and happily!) out of date. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants