Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty :root blocks are being output in CSS #80

Closed
2 tasks
erikjung opened this issue Aug 10, 2015 · 3 comments
Closed
2 tasks

Empty :root blocks are being output in CSS #80

erikjung opened this issue Aug 10, 2015 · 3 comments

Comments

@erikjung
Copy link
Contributor

Because of block comments within :root blocks, our CSS output has many instances of:

:root {
}

We should think about:

@tylersticka
Copy link
Member

Would this be resolved by optimization tasks when we get to the point where we're building production CSS files?

@erikjung
Copy link
Contributor Author

I bet the comment removal would, but I'm not sure about the empty blocks. Though, I still think it's worth it to have these quirks cleaned up in our working output to make it easier to look at during development.

@erikjung
Copy link
Contributor Author

Closed via #81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants