Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine solution or official recommendation for autofill issues #15

Open
javayoung opened this issue Sep 24, 2014 · 4 comments
Open

Comments

@javayoung
Copy link

The plug in works so well. But it just has a weird issue. When the user name or the password input have not been set up with any value, it will automatically show the browser saved user name and password for the current webpage. Is there a way to not show browser saved user name and password? Thank you
untitled

@tylersticka
Copy link
Member

Ah, the dreaded browser autofill. This shouldn't have anything to do with the plugin, but with the behavior of the username/password fields on your page. (If you were to remove the plugin but keep the <input> elements, I'd bet you'd still see them auto-filled.)

In a future version of the plugin, I'd like to have some sort of "recommended" option for dealing with this. Currently, there's no magic solution.

One thing you can do is try disabling the browser autofill on the <input> elements themselves. I recommend this Mozilla article for doing that.

You can also just hide the password by default. If that's not your style, you could defer enabling that field until you're sure it isn't autofilled... though that can be complicated. There are many techniques for doing so and even an autofill event plugin.

We'll be exploring this further in the future. In the meantime, if you stumble upon a combination of solutions that work for you, please let us know so we can incorporate that knowledge into the plugin.

@javayoung
Copy link
Author

Oh, thank you for your quick and elaborate reply. 👍

I see your point about the autofill issue. I will also think over how to counter it based on your idea and will let you know. Meanwhile, i will keep watching your github. :0) Thank you so much for your reply.

@simevidas
Copy link

I think the ideal implementation of the “Show password” feature would be as follows:

  1. the control is initially disabled (HTML disabled attribute)
  2. when the user edits the password field for the first time, confirm the the current value has been produced from user input (i.e. it wasn’t autofilled), and only then enable the control

You can see this functionality in practice here: https://www.youtube.com/watch?v=Dt8np9kYCVM

@tylersticka Please consider adding this as an option.

@tylersticka
Copy link
Member

Thanks, @simevidas! Regarding this portion:

when the user edits the password field for the first time, confirm the the current value has been produced from user input (i.e. it wasn’t autofilled)

Any advice on how one would reliably do that?

@tylersticka tylersticka changed the title Automatically show browser saved user name and password even the input value is empty Determine solution or official recommendation for autofill issues Jun 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants