fix(protobuf): map file paths correctly for filesystem and git configurations #272
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue when using imports with protobuf described in #265.
Filesystem proto configuration
When files were indexed in
filesStr
, they were index as the full file path instead of the cleaned up file path. This resulted in protobuf trying to go to the file system for the path, but the file path used represented is not a fully qualified path.Git proto configuration
Git experienced a similar issue as
filesystem
, so I added the relevant code there as well. However, it was a little different because I would need to "remove" thebaseDirectory
path from thefilePath
instead.I've tested from both configurations, and it seems to work for me.