Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Cloudinary Product Gallery Widget #132

Open
colbyfayock opened this issue Feb 17, 2023 · 5 comments
Open

[Feature] Cloudinary Product Gallery Widget #132

colbyfayock opened this issue Feb 17, 2023 · 5 comments
Assignees

Comments

@colbyfayock
Copy link
Collaborator

colbyfayock commented Feb 17, 2023

Feature Request

Is your feature request related to a problem? Please describe.

https://cloudinary.com/documentation/product_gallery

Describe the solution you'd like

<CldProductGallery ... />

The component should reflect the same patterns used for the CldUploadWidget both in how the scripts are loaded and how the options are managed and passed in.

The initial options made available should be typed.

The initial iteration of this can be an MVP to get a basic product gallery working without extensive top level prop support, such as an options option that can expose the core Product Gallery API.

@Vishalk91-4
Copy link

@colbyfayock, I would like to work on this, cqan you assign it to me
Could you tell me more about what all things are needed to be added

@colbyfayock
Copy link
Collaborator Author

hey @Vishalk91-4 sure thing!

The goal of this ticket is to create a new component, CldProductGallery, that would act as a wrapper around the Cloudinary Product Gallery widget: https://cloudinary.com/documentation/product_gallery

This widget uses a script include to load as well as some initialization code. The idea would be this would all be included to make it easy for someone to drop on a page with an intuitive API.

A good example of a component that does something similar is CldUploadWidget: https://github.com/colbyfayock/next-cloudinary/blob/main/next-cloudinary/src/components/CldUploadWidget/CldUploadWidget.tsx

You could certainly use that as an example for how you create the Product Gallery component

Additionally here's some reference code for getting it started: https://github.com/cloudinary-community/cloudinary-examples/tree/main/examples/react-product-gallery

Though it could use some optimization for how the script loads and all, which you could get inspiration from the Upload Widget

let me know what you think!

@colbyfayock
Copy link
Collaborator Author

@Vishalk91-4 are you still working on this?

@Vishalk91-4
Copy link

@colbyfayock Yes, will be submitting the PR tomorrow

@colbyfayock
Copy link
Collaborator Author

hey @Vishalk91-4 did you still plan on working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants