We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A @ts-ignore is currently in place in the CldVideoPlayer component which is utilizing a videojs method to dispose of the player
https://github.com/cloudinary-community/next-cloudinary/blob/main/next-cloudinary/src/components/CldVideoPlayer/CldVideoPlayer.tsx#L227-L228
Goal would be to address whatever type issues are preventing this line from being removed.
There is a dispose method on the player itself but it was causing issues apparently. so the answer may be adding the type somewhere, which now exist inside of https://github.com/colbyfayock/cloudinary-util/blob/main/packages/types/src/types/cloudinary-video-player.d.ts
some context: #317 (comment)
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Bug Report
Describe the bug
A @ts-ignore is currently in place in the CldVideoPlayer component which is utilizing a videojs method to dispose of the player
https://github.com/cloudinary-community/next-cloudinary/blob/main/next-cloudinary/src/components/CldVideoPlayer/CldVideoPlayer.tsx#L227-L228
Goal would be to address whatever type issues are preventing this line from being removed.
There is a dispose method on the player itself but it was causing issues apparently. so the answer may be adding the type somewhere, which now exist inside of https://github.com/colbyfayock/cloudinary-util/blob/main/packages/types/src/types/cloudinary-video-player.d.ts
some context: #317 (comment)
The text was updated successfully, but these errors were encountered: