Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secure Distribution / Cname Environment Variables, CldVideoPlayer Config #466

Merged
merged 6 commits into from
Apr 11, 2024
Merged

Secure Distribution / Cname Environment Variables, CldVideoPlayer Config #466

merged 6 commits into from
Apr 11, 2024

Conversation

colbyfayock
Copy link
Collaborator

@colbyfayock colbyfayock commented Apr 11, 2024 •
edited
Loading

Description

  • Global cname/secure distribution
  • CldVideoPlayer config prop
  • CldUploadWidget config prop

Adds the ability to configure an environment variable for global cname/secure distribution configuration

NEXT_PUBLIC_CLOUDINARY_SECURE_DISTRIBUTION="spacejelly.dev"
NEXT_PUBLIC_CLOUDINARY_PRIVATE_CDN=true

Currently opting not to provide an option for the cname parameter as that's considered legacy and only used for insecure contexts, which is not recommended

See: https://cloudinary.com/documentation/cloudinary_sdks#configuration_parameters

Adds config prop to CldVideoPlayer and CldUploadWidget for individual configuration. This also inherits the global configurations as relevant.

Issue Ticket Number

Fixes #465
Fixes #464

@vercel Vercel
Copy link

vercel bot commented Apr 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
next-cloudinary ✅ Ready (Inspect) Visit Preview Apr 11, 2024 10:11pm

@colbyfayock colbyfayock changed the title Secure Distribution / Cname Environment Variables Secure Distribution / Cname Environment Variables, CldVideoPlayer Config Apr 11, 2024
@colbyfayock colbyfayock merged commit 9cafdac into main Apr 11, 2024
7 checks passed
@colbyfayock colbyfayock deleted the feat/465-global-cname branch April 11, 2024 22:13
github-actions bot pushed a commit that referenced this pull request Apr 11, 2024
@semantic-release-bot
chore(release): 6.5.0 [skip ci]
703bfe2 
# [6.5.0](v6.4.1...v6.5.0) (2024-04-11)

### Features

* Secure Distribution / Cname Environment Variables, CldVideoPlayer Config ([#466](#466)) ([9cafdac](9cafdac)), closes [#465](#465) [#464](#464)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 6.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Apr 12, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
1 participant
@colbyfayock