Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6.6.0 - CldVideoPlayer getVideoPlayerOptions (#477) #478

Merged
merged 2 commits into from
May 23, 2024
Merged

Conversation

colbyfayock
Copy link
Collaborator

Description

Updates CldVideoPlayer to use getVideoPlayerProps from the @cloudinary-util/url-loader package to abstract how we ultimately construct the player options object. This will allow other frameworks (Nuxt, Svelte) to share the same code and maintain parity at a higher rate.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Fix or improve the documentation
  • This change requires a documentation update

Checklist

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • I have created an issue ticket for this PR
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have run tests locally to ensure they all pass
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation

Description

Issue Ticket Number

Fixes #<ISSUE_NUMBER>

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Fix or improve the documentation
  • This change requires a documentation update

Checklist

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • I have created an issue ticket for this PR
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have run tests locally to ensure they all pass
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation

colbyfayock and others added 2 commits May 23, 2024 12:28
# Description

Updates CldVideoPlayer to use getVideoPlayerProps from the
@cloudinary-util/url-loader package to abstract how we ultimately
construct the player options object. This will allow other frameworks
(Nuxt, Svelte) to share the same code and maintain parity at a higher
rate.

<!-- Specify above which issue this fixes by referencing the issue
number (`#<ISSUE_NUMBER>`) or issue URL. -->
<!-- Example: Fixes
https://github.com/cloudinary-community/next-cloudinary/issues/<ISSUE_NUMBER>
-->

## Type of change

<!-- Please select all options that are applicable. -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Fix or improve the documentation
- [ ] This change requires a documentation update


# Checklist

<!-- These must all be followed and checked. -->

- [ ] I have followed the contributing guidelines of this project as
mentioned in [CONTRIBUTING.md](/CONTRIBUTING.md)
- [ ] I have created an
[issue](https://github.com/cloudinary-community/next-cloudinary/issues)
ticket for this PR
- [ ] I have checked to ensure there aren't other open [Pull
Requests](https://github.com/cloudinary-community/next-cloudinary/pulls)
for the same update/change?
- [ ] I have performed a self-review of my own code
- [ ] I have run tests locally to ensure they all pass
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes needed to the documentation
# [6.6.0-beta.1](v6.5.2...v6.6.0-beta.1) (2024-05-23)

### Features

* CldVideoPlayer - getVideoPlayerOptions ([#477](#477)) ([4ad73c5](4ad73c5))
Copy link

vercel bot commented May 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
next-cloudinary ✅ Ready (Inspect) Visit Preview May 23, 2024 4:33pm

@colbyfayock colbyfayock merged commit b07fe7f into main May 23, 2024
1 check passed
@colbyfayock colbyfayock deleted the beta branch May 23, 2024 17:00
github-actions bot pushed a commit that referenced this pull request May 23, 2024
# [6.6.0](v6.5.2...v6.6.0) (2024-05-23)

### Features

* v6.6.0 - CldVideoPlayer getVideoPlayerOptions ([#477](#477)) ([#478](#478)) ([b07fe7f](b07fe7f))
Copy link

🎉 This PR is included in version 6.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants