Flysystem problem for Laravel 9

[chrisschale]

Hey,

in version 1.0.5 the CloudinaryAdapter still uses the NotSupportingVisibilityTrait which doesn't exist anymore in Flysystem 3. The latter is used in Laravel 9.

Best regards,
Chris

[lukdiekm]

Same problem here

[tobz-nz]

This issue still remains.

#55 only enabled it to be installed on Laravel 9, but did not ensure full comparability

Related: #57 and #59

[rushi7997]

Can someone Please fix this?

[phuclh]

I have the same issue

[unicodeveloper]

@phuclh what's the issue you experience here? Can you be more detailed about it so I can fix it ASAP.

[phuclh]

in version 1.0.5 the CloudinaryAdapter still uses the NotSupportingVisibilityTrait which doesn't exist anymore in Flysystem 3. The latter is used in Laravel 9.

In version 1.0.5, the CloudinaryAdapter still uses the NotSupportingVisibilityTrait which doesn't exist anymore in Flysystem 3.

[rushi7997]

@unicodeveloper, can you please fix this issue? I am migrating my application to Laravel 9, and I am stuck because of this package. Thanks

[unicodeveloper]

@rushi7997 please submit a PR.

[phuclh]

Hi @unicodeveloper , do you or Cloundinary team have any plans to fix this issue?

[unicodeveloper]

Please send in a PR

On Thu, Apr 28, 2022 at 4:57 AM phuclh ***@***.***> wrote: Hi @unicodeveloper <https://github.com/unicodeveloper> , do you or Cloundinary team have any plans to fix this issue? — Reply to this email directly, view it on GitHub <#64 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAWPNUM4OPT4XWJWE2S2U5TVHHV7RANCNFSM5R3AKGVA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- *Best Regards,* *Prosper Otemuyiwa* *Co-founder, Eden* @unicodeveloper <https://twitter.com/unicodeveloper> | prosper.otemuyiwa1 ( *Skype* )

[brandon14]

@unicodeveloper It seems that the adapter shipped with this package was written for a 1.x flysystem adapter, so in order to truly support Laravel 9.x, it will likely involve rewriting the CloudinaryAdapter to be compatible with flysystem 3.x.

I am not sure if a flysystem adapter supports both 1.x and 3.x is possible because I haven't looked to much into the documentation for flysystem, but the notable change sin 2.x and 3.x can be found here: https://flysystem.thephpleague.com/docs/what-is-new/

[rushi7997]

According to the documentation here

Every adapter must implement the League\Flysystem\FilesystemAdapter interface. This interface defines all the required methods and lists which exceptions should be thrown in case of failure.

we have to rewrite CloudinaryAdapter implementing FilesystemAdapter from flysystem 3.x

the current version implements the interface AdapterInterface which is no longer available in flysystem 3.x

[phuclh]

I re-wrote the CloudinaryAdapter that implements Flysystem 3.x here: https://github.com/phuclh/flysystem-cloudinary. This package is just flysystem driver. It doesn't have all features like this package but it works with Laravel 9

[unicodeveloper]

@rushi7997 @brandon14 @phuclh I just tagged a v2.0.0 that solves this issue. Everyone on Laravel 9 can use the package without issues now.

[brandon14]

@unicodeveloper I think there still may be some issues with this in applications that stick strictly to the Flysystem contracts. The listContents() method, should return an iterable, but the elements must be instances of StorageAttributes, not plain arrays.

So in something like Statamic for example, if using this as an asset driver, it breaks because the Statamic code expects the listContents() of a 3.x Flysystem adapter to adhere to the contact defined for Flysystem 3.x.

/**
     * @return iterable<StorageAttributes>
     *
     * @throws FilesystemException
     */
    public function listContents(string $path, bool $deep): iterable;

I don't care to submit a PR targeting the 2.x branch of this package to change the return of that method to return an iterable of StorageAttributes to solve this issue.

[unicodeveloper]

@brandon14 you have a point. I missed this. Please can you submit a PR targeting the dev-v2 branch? I'll really appreciate.