ME-14380-lazy-ads #535
Merged
ME-14380-lazy-ads #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…video-player into ME-14380-lazy-ads
ehab-cl
approved these changes
Feb 5, 2024
| @@ -67,7 +67,6 @@ <h3 class="mb-4">VAST and VPAID</h3> | |||
| playsinline | |||
| controls | |||
| muted | |||
| autoplay | |||
There was a problem hiding this comment.
Since the non autoplay was causing a bug it seems that autoplay can be a factor, i would provide two examples one with autoplay and one without.
Comment on lines
+1
to
+3
| import 'videojs-contrib-ads'; | ||
| import 'videojs-ima'; | ||
| import 'videojs-ima/dist/videojs.ima.scss'; |
There was a problem hiding this comment.
This versus having the library code getting copied is 🕺 🚀
| @@ -38,11 +36,11 @@ export default function imaPlugin(player, playerOptions) { | |||
| if (Object.keys(playerOptions.ads).length > 0 && typeof player.ima === 'object') { | |||
| if (playerOptions.ads.adsInPlaylist === 'first-video') { | |||
| player.one(PLAYER_EVENT.SOURCE_CHANGED, () => { | |||
| player.ima.playAd(); | |||
| player.ima.playAdBreak(); | |||
There was a problem hiding this comment.
what is the difference between these two methods? just curious or is it just a rename?
There was a problem hiding this comment.
I didn't look too deep into the history of the change, but looks like it was renamed
✅ Deploy Preview for vp-build ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This was referenced Feb 13, 2024
Merged
This was referenced Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.