Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bump video analytics, trigger analytics event only once #637

Merged
merged 2 commits into from
May 28, 2024
Merged

fix: bump video analytics, trigger analytics event only once #637

merged 2 commits into from
May 28, 2024

Conversation

jakub-roch
Copy link
Contributor

Bump video analytics package version
Trigger source change event only once

@jakub-roch jakub-roch requested a review from a team as a code owner May 28, 2024 10:59
@netlify Netlify
Copy link

netlify bot commented May 28, 2024 •
edited
Loading

✅ Deploy Preview for cld-video-player ready!

Name Link
🔨 Latest commit 352380b
🔍 Latest deploy log https://app.netlify.com/sites/cld-video-player/deploys/6655b997c7dbfb000854d55a
😎 Deploy Preview https://deploy-preview-637--cld-video-player.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented May 28, 2024 •
edited
Loading

✅ Deploy Preview for cld-vp-esm-pages ready!

Name Link
🔨 Latest commit 352380b
🔍 Latest deploy log https://app.netlify.com/sites/cld-vp-esm-pages/deploys/6655b9972a051500087b7202
😎 Deploy Preview https://deploy-preview-637--cld-vp-esm-pages.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

tsi
tsi approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@tsi tsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jakub-roch jakub-roch merged commit cbb0d07 into edge May 28, 2024
9 checks passed
@cloudinary-jenkins cloudinary-jenkins mentioned this pull request May 28, 2024
Merged
tsi added a commit that referenced this pull request Jun 10, 2024
@tsi
Merge branch 'edge'
d5f7a77 
fix: handle live streams (#641)

fix: text track with no src should fall-back to transcript (#640)

fix: bump video analytics, trigger analytics event only once (#637)

fix: prevent undefined error when seek-thumbnails are unavailable (#635)
tsi added a commit that referenced this pull request Jun 10, 2024
@tsi
fix: handle live streams (#641)
1b04cc8 
fix: handle live streams (#641)

fix: text track with no src should fall-back to transcript (#640)

fix: bump video analytics, trigger analytics event only once (#637)

fix: prevent undefined error when seek-thumbnails are unavailable (#635)
This was referenced Jun 10, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsi tsi tsi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jakub-roch @tsi