Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow.py graph save does not handle paths with dots in them correctly #44

Closed
jpfleischer opened this issue Sep 8, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@jpfleischer
Copy link
Member

    if engine == "dot":
            prefix, ending = filename.split(".")
            dot_filename = prefix + ".dot"
            writefile(dot_filename, str(dot.source))
            os.system(f"dot -T{ending} {dot_filename} -o {filename}")

this fails when filename is something like ~/.cloudmesh/workflow/workflow/workflow.svg

@jpfleischer jpfleischer added the bug Something isn't working label Sep 8, 2022
@jpfleischer jpfleischer self-assigned this Sep 8, 2022
@jpfleischer
Copy link
Member Author

we easily fix by using

      basefilename = os.path.basename(filename)
      prefix, ending = basefilename.split(".")

fix will be pushed soon

@jpfleischer
Copy link
Member Author

fixed 9ad6d45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant