Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: detect PodSpec drift in pod rollout, and clarify rollout code #2243

Merged
merged 20 commits into from
Aug 23, 2023
Merged

chore: detect PodSpec drift in pod rollout, and clarify rollout code #2243

merged 20 commits into from
Aug 23, 2023

Conversation

jsilvela
Copy link
Collaborator

@jsilvela jsilvela commented Jun 9, 2023 •
edited

  • Add pod annotation with original PodSpec to detect drift.
  • Use a standard structure for the functions checking if
    rollout is needed.
  • Fix logic that could allow a rollout with a Postgres image
    from a different major version.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.18 release-1.19 release-1.20 labels Jun 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@sxd sxd removed the release-1.18 label Jun 13, 2023
@jsilvela
Copy link
Collaborator Author

/test

@github-actions
Copy link
Contributor

@jsilvela, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/5380798021

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

6 similar comments
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@jsilvela
Copy link
Collaborator Author

/test

@github-actions
Copy link
Contributor

@jsilvela, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/5390994815

@github-actions github-actions bot added the ok to merge 👌 This PR can be merged label Jun 27, 2023
@armru
Copy link
Member

armru commented Jun 28, 2023

/test limit=local

jsilvela and others added 10 commits August 22, 2023 15:04
@jsilvela @mnencia
review: rename rollout reconciler
2b077ef 
Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
@jsilvela @mnencia
fix: unused annotation label
ba6bb1a 
Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
@jsilvela @mnencia
chore: reduce diff
c69055e 
Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
@armru @mnencia
chore: do not export types that are not needed
fffd289 
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
@armru @mnencia
chore: always specify the resource in the messages
dc77197 
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
@jsilvela @mnencia
fix: unit test
0e3326a 
Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
@jsilvela @mnencia
chore: store the podSpec rather than the resources
9815824 
Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
@jsilvela @mnencia
fix: linter
4031ca8 
Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
@jsilvela @mnencia
fix: linter
7f99546 
Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
@jsilvela @mnencia
review: cleanup
7b10ce6 
Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
@mnencia
Copy link
Member

mnencia commented Aug 22, 2023

/test tl=4

@github-actions
Copy link
Contributor

@mnencia, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/5939246215

@mnencia
Copy link
Member

mnencia commented Aug 22, 2023

/test

@github-actions
Copy link
Contributor

@mnencia, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/5941544994

@mnencia
chore: change some names
d709704 
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
@mnencia
chore: improve messages
021081c 
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
@mnencia mnencia merged commit 26d1f23 into main Aug 23, 2023
22 checks passed
@mnencia mnencia deleted the dev/cnp-3741 branch August 23, 2023 09:58
cnpg-bot pushed a commit that referenced this pull request Aug 23, 2023
@jsilvela
feat: improve detection of Pod rollout conditions (#2243)
d2b4611 
This patch implements a robust algorithm to detect when the operator
should roll out a Pod. Since the Kubernetes environment may change
the Pod definition, the requested podSpec built from the Cluster is stored
for comparison to detect drift.

Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
(cherry picked from commit 26d1f23)
cnpg-bot pushed a commit that referenced this pull request Aug 23, 2023
@jsilvela
feat: improve detection of Pod rollout conditions (#2243)
ff0de81 
This patch implements a robust algorithm to detect when the operator
should roll out a Pod. Since the Kubernetes environment may change
the Pod definition, the requested podSpec built from the Cluster is stored
for comparison to detect drift.

Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
(cherry picked from commit 26d1f23)
@mnencia mnencia mentioned this pull request Aug 23, 2023
Merged
mnencia added a commit that referenced this pull request Aug 24, 2023
@mnencia
fix: encode podSpecAnnotation content in JSON (#2618)
fff7bb3 
The PR #2243 mistakenly used the Protocol Buffers encoding
for the podSpec annotation content. 
This commit changes the encoding to JSON as intended.

Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
litaocdl pushed a commit that referenced this pull request Aug 29, 2023
@jsilvela @armru
@mnencia @litaocdl
feat: improve detection of Pod rollout conditions (#2243)
21ee5c9 
This patch implements a robust algorithm to detect when the operator
should roll out a Pod. Since the Kubernetes environment may change
the Pod definition, the requested podSpec built from the Cluster is stored
for comparison to detect drift.

Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
litaocdl pushed a commit that referenced this pull request Aug 29, 2023
@jsilvela @armru
@mnencia @litaocdl
feat: improve detection of Pod rollout conditions (#2243)
71bbaf7 
This patch implements a robust algorithm to detect when the operator
should roll out a Pod. Since the Kubernetes environment may change
the Pod definition, the requested podSpec built from the Cluster is stored
for comparison to detect drift.

Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
litaocdl pushed a commit that referenced this pull request Nov 2, 2023
@mnencia @litaocdl
fix: encode podSpecAnnotation content in JSON (#2618)
0228a66 
The PR #2243 mistakenly used the Protocol Buffers encoding
for the podSpec annotation content. 
This commit changes the encoding to JSON as intended.

Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
litaocdl pushed a commit that referenced this pull request Nov 2, 2023
@mnencia @litaocdl
fix: encode podSpecAnnotation content in JSON (#2618)
fd920d2 
The PR #2243 mistakenly used the Protocol Buffers encoding
for the podSpec annotation content. 
This commit changes the encoding to JSON as intended.

Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
@jsilvela jsilvela mentioned this pull request Jan 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnencia mnencia mnencia approved these changes

@armru armru armru approved these changes

@fcanovai fcanovai Awaiting requested review from fcanovai

@gbartolini gbartolini Awaiting requested review from gbartolini

@leonardoce leonardoce Awaiting requested review from leonardoce

@phisco phisco Awaiting requested review from phisco

@sxd sxd Awaiting requested review from sxd

Assignees
No one assigned
Labels
backport-requested ◀️ This pull request should be backported to all supported releases no-issue ok to merge 👌 This PR can be merged release-1.19 release-1.20
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jsilvela @armru @mnencia @sxd