Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add phase PhaseWaitNotActiveInstances #2612

Merged
merged 6 commits into from
Sep 18, 2023
Merged

feat: add phase PhaseWaitNotActiveInstances #2612

merged 6 commits into from
Sep 18, 2023

Conversation

armru
Copy link
Member

@armru armru commented Aug 22, 2023

Closes #2611

@github-actions github-actions bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.19 release-1.20 labels Aug 22, 2023
@github-actions
Copy link
Contributor

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

@armru
Copy link
Member Author

armru commented Aug 22, 2023

/test limit=local

@github-actions
Copy link
Contributor

@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/5937442535

@armru
Copy link
Member Author

armru commented Sep 4, 2023

/test limit=local

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/6071322370

@armru
Copy link
Member Author

armru commented Sep 4, 2023

/test limit=local

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/6074002031

@armru armru added the risk 💥 Risk/Compliance label Sep 4, 2023
@armru
Copy link
Member Author

armru commented Sep 4, 2023

Very risky PR, has a lot of implications. Adding the label

@armru
Copy link
Member Author

armru commented Sep 11, 2023

/test limit=local

@github-actions
Copy link
Contributor

@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/6146259270

armru and others added 4 commits September 18, 2023 14:32
@armru @mnencia
feat: add phase PhaseWaitNotActiveInstances
eb7eac6 
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
@armru @mnencia
chore: improvements
8e4d602 
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
@armru @mnencia
fix: handle inplace
6e07f78 
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
@litaocdl @mnencia
minor change for terming
d116a38 
Signed-off-by: Tao Li <tao.li@enterprisedb.com>
@mnencia
chore: improve naming
7d52ba5 
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
@mnencia
Copy link
Member

mnencia commented Sep 18, 2023

/ok-to-merge E2e failure are unrelated (replication slots)

@cnpg-bot cnpg-bot added the ok to merge 👌 This PR can be merged label Sep 18, 2023
phisco
phisco approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@phisco phisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except for the debug log which still needs to be updated as we discussed, LGTM! 🎉

@mnencia
docs: more naming
a63c768 
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
@mnencia mnencia merged commit 0b29e81 into main Sep 18, 2023
22 checks passed
@mnencia mnencia deleted the dev/2611 branch September 18, 2023 14:12
cnpg-bot pushed a commit that referenced this pull request Sep 18, 2023
@armru
feat: add new phase Waiting for the instances to become active (#2612)
c744cf1 
Add an explicit phase to state we wait for some instances to become ready.

Previously, the operator retained the previous phase until all the instances
were ready. (e.g., remaining in the `failing over` phase for a long time
after the actual failover was done)

Closes #2611

Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Tao Li <tao.li@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Tao Li <tao.li@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
(cherry picked from commit 0b29e81)
cnpg-bot pushed a commit that referenced this pull request Sep 18, 2023
@armru
feat: add new phase Waiting for the instances to become active (#2612)
52f53c0 
Add an explicit phase to state we wait for some instances to become ready.

Previously, the operator retained the previous phase until all the instances
were ready. (e.g., remaining in the `failing over` phase for a long time
after the actual failover was done)

Closes #2611

Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Tao Li <tao.li@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Tao Li <tao.li@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
(cherry picked from commit 0b29e81)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnencia mnencia mnencia approved these changes

@phisco phisco phisco approved these changes

@litaocdl litaocdl litaocdl approved these changes

@fcanovai fcanovai Awaiting requested review from fcanovai

@gbartolini gbartolini Awaiting requested review from gbartolini

@leonardoce leonardoce Awaiting requested review from leonardoce

@sxd sxd Awaiting requested review from sxd

Assignees

@mnencia mnencia

@armru armru

Labels
backport-requested ◀️ This pull request should be backported to all supported releases ok to merge 👌 This PR can be merged release-1.19 release-1.20 risk 💥 Risk/Compliance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

explicitly communicate that we are waiting for the instances to become active
5 participants
@armru @mnencia @phisco @litaocdl @cnpg-bot