fix(monitoring): improve accuracy of replica lag #2750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbartolini
requested review from
fcanovai,
leonardoce,
mnencia,
phisco,
sxd and
armru
as code owners
github-actions
bot
added
backport-requested ◀️
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
❗ By default, the pull request is configured to backport to all release branches.
|
phisco
approved these changes
Sep 12, 2023
gbartolini
force-pushed
the
dev/1814-b
branch
from
6f374cd
to
1b0e5a0
Compare
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
sxd
approved these changes
Sep 12, 2023
This patch overrides the previous patch which only covered the documentation samples. From a deeper analysis, we noticed that some examples had already been introduced in the default monitoring config map, thus have been removed from the docs. The default configmap now fixes the `pg_replication` metric to use the `pg_last_wal_receive_lsn()` and `pg_last_wal_replay_lsn()` functions to better estimate the lag of a replica, and avoid the increase of the lag on inactive systems. Closes #1814 Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
gbartolini
force-pushed
the
dev/1814-b
branch
from
1b0e5a0
to
27b5535
Compare
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
cnpg-bot
pushed a commit
that referenced
this pull request
Sep 12, 2023
This patch overrides the previous patch which only covered the documentation samples. From a deeper analysis, we noticed that some examples had already been introduced in the default monitoring config map, thus have been removed from the docs. The default configmap now fixes the `pg_replication` metric to use the `pg_last_wal_receive_lsn()` and `pg_last_wal_replay_lsn()` functions to better estimate the lag of a replica, and avoid the increase of the lag on inactive systems. Closes #1814 Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> (cherry picked from commit 6b7b91c)
mnencia
pushed a commit
that referenced
this pull request
Sep 13, 2023
This patch overrides the previous patch which only covered the documentation samples. From a deeper analysis, we noticed that some examples had already been introduced in the default monitoring config map, thus have been removed from the docs. The default configmap now fixes the `pg_replication` metric to use the `pg_last_wal_receive_lsn()` and `pg_last_wal_replay_lsn()` functions to better estimate the lag of a replica, and avoid the increase of the lag on inactive systems. Closes #1814 Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch overrides the previous patch which only covered the documentation samples. From a deeper analysis, we noticed that some examples had already been introduced in the default monitoring config map, thus have been removed from the docs.
The default configmap now fixes the
pg_replicationmetric to use thepg_last_wal_receive_lsn()andpg_last_wal_replay_lsn()functions to better estimate the lag of a replica, and avoid the increase of the lag on inactive systems.Closes #1814