feat: support startupProbe in instance pod #2847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
litaocdl
requested review from
fcanovai,
gbartolini,
leonardoce,
mnencia,
phisco,
sxd and
armru
as code owners
github-actions
bot
added
backport-requested ◀️
|
❗ By default, the pull request is configured to backport to all release branches.
|
gbartolini
reviewed
Sep 22, 2023
litaocdl
changed the title
|
/test limit=local |
YanniHu1996
approved these changes
Sep 22, 2023
|
@litaocdl, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/6273031091 |
Signed-off-by: Tao Li <tao.li@enterprisedb.com>
Signed-off-by: Tao Li <tao.li@enterprisedb.com>
Signed-off-by: YanniHu1996 <yantian.hu@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
gbartolini
added
the
always push images
gbartolini
approved these changes
Sep 22, 2023
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
gbartolini
added a commit
that referenced
this pull request
Sep 22, 2023
IMPORTANT: The default value of `startDelay` has now been changed to 3600 seconds, equivalent of 1 hour. Previously, it was set to 30 seconds. This patch also replaces the livenessProbe's initial delay with a more proper Kubernetes startup probe to deal with the start of a Postgres server. Both the startup probe and the higher default time should improve the self-healing capabilities of larger Postgres deployments where the default value of 30 seconds was not sufficient for example to complete a crash recovery operation, causing infinite restarts. Closes #2843 Signed-off-by: Tao Li <tao.li@enterprisedb.com> Signed-off-by: YanniHu1996 <yantian.hu@enterprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Co-authored-by: YanniHu1996 <yantian.hu@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
gbartolini
added a commit
that referenced
this pull request
Sep 22, 2023
IMPORTANT: The default value of `startDelay` has now been changed to 3600 seconds, equivalent of 1 hour. Previously, it was set to 30 seconds. This patch also replaces the livenessProbe's initial delay with a more proper Kubernetes startup probe to deal with the start of a Postgres server. Both the startup probe and the higher default time should improve the self-healing capabilities of larger Postgres deployments where the default value of 30 seconds was not sufficient for example to complete a crash recovery operation, causing infinite restarts. Closes #2843 Signed-off-by: Tao Li <tao.li@enterprisedb.com> Signed-off-by: YanniHu1996 <yantian.hu@enterprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Co-authored-by: YanniHu1996 <yantian.hu@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this patch provide the startupProbe support for postgres pod,
the failureThreshold of startupProbe is calculated by startDelay / PeriodSeconds,
while PeriodSeconds is use default 10 seconds. startDelay by default is 3600
closes: #2843