Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable replications slots for HA by default #2903

Merged
merged 3 commits into from
Sep 29, 2023
Merged

feat: enable replications slots for HA by default #2903

merged 3 commits into from
Sep 29, 2023

Conversation

gbartolini
Copy link
Contributor

@gbartolini gbartolini commented Sep 27, 2023 •
edited by jsilvela

IMPORTANT: the .spec.replicationSlots.highAvailability.enabled parameter is now by default set to true. This change was already anticipated in the upgrade instructions of CloudNativePG 1.20.

Closes #2673

@gbartolini gbartolini added the do not backport This PR must not be backported - it will be in the next minor release label Sep 27, 2023
@gbartolini gbartolini self-assigned this Sep 27, 2023
@gbartolini gbartolini added this to the 1.21.0 milestone Sep 27, 2023
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.19 release-1.20 labels Sep 27, 2023
@github-actions
Copy link
Contributor

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@gbartolini gbartolini removed backport-requested ◀️ This pull request should be backported to all supported releases release-1.19 release-1.20 labels Sep 27, 2023
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

2 similar comments
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@gbartolini
Copy link
Contributor Author

/test

@github-actions
Copy link
Contributor

@gbartolini, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/6327067955

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

gbartolini and others added 3 commits September 29, 2023 12:41
@gbartolini @jsilvela
feat: enable replications slots for HA by default
1fa801d 
IMPORTANT: the `.spec.replicationSlots.highAvailability.enabled` parameter is
now by default set to `true`. This change was already anticipated in the
upgrade instructions of CloudNativePG 1.20.

Closes #2673

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
@sxd @jsilvela
chore: review
e87b4cc 
Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com>
@jsilvela
chore: small revisions
11ea273 
Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
@jsilvela
Copy link
Collaborator

/ok-to-merge

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@cnpg-bot cnpg-bot added the ok to merge 👌 This PR can be merged label Sep 29, 2023
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@jsilvela jsilvela merged commit dfcca09 into main Sep 29, 2023
21 of 24 checks passed
@jsilvela jsilvela deleted the dev/2673 branch September 29, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsilvela jsilvela jsilvela approved these changes

@sxd sxd sxd approved these changes

@YanniHu1996 YanniHu1996 YanniHu1996 approved these changes

@fcanovai fcanovai Awaiting requested review from fcanovai

@leonardoce leonardoce Awaiting requested review from leonardoce

@mnencia mnencia Awaiting requested review from mnencia

@phisco phisco Awaiting requested review from phisco

@armru armru Awaiting requested review from armru

Assignees

@gbartolini gbartolini

Labels
do not backport This PR must not be backported - it will be in the next minor release ok to merge 👌 This PR can be merged
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.

Enable replication slots for HA by default
5 participants
@gbartolini @jsilvela @sxd @YanniHu1996 @cnpg-bot