fix: prevent stuck cluster when primary database is down but pod is up #2966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsilvela
requested review from
fcanovai,
gbartolini,
leonardoce,
mnencia,
phisco,
sxd and
armru
as code owners
github-actions
bot
added
backport-requested ◀️
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
❗ By default, the pull request is configured to backport to all release branches.
|
Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
jsilvela
changed the title
|
/test |
|
@jsilvela, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/6383672533 |
jsilvela
changed the title
Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
leonardoce
force-pushed
the
dev/cnp-4198
branch
from
593520e
to
91cbd7c
Compare
|
/test |
|
@leonardoce, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/6391306590 |
leonardoce
approved these changes
Oct 3, 2023
mnencia
approved these changes
Oct 3, 2023
cnpg-bot
pushed a commit
that referenced
this pull request
Oct 3, 2023
#2966) Fixes a condition that could result in the primary database being down while the corresponding pod is still up. When this happens, the reconciliation of replication slots and managed roles will error out, preventing the instance manager from shutting down the primary and preventing switch-overs and fail-overs from finishing correctly. Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com> Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com> Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Co-authored-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com> Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> (cherry picked from commit 5e36af8)
leonardoce
added a commit
that referenced
this pull request
Oct 3, 2023
#2966) Fixes a condition that could result in the primary database being down while the corresponding pod is still up. When this happens, the reconciliation of replication slots and managed roles will error out, preventing the instance manager from shutting down the primary and preventing switch-overs and fail-overs from finishing correctly. Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com> Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com> Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Co-authored-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com> Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a condition that could happen when the primary database
is down, but the pod is still up.
In such case, the reconciliation of replication slots or managed roles
could error out, and prevent the instance manager from shutting down
the primary. This would leave the cluster unable to fail over.