feat: enhance the `plugin status` command #3101

YanniHu1996 · 2023-10-17T06:29:02Z

closes: #3011

While working on this issue, I found that we have an opportunity to reduce the response time of status API by the way used in this PR

cloudnative-pg/pkg/management/postgres/probes.go

Lines 66 to 73 in af347f7

    
           // StatusOption is as a function to select which information to include in the status 
        
           type StatusOption func(*StatusSelection) 
        
           // StatusSelection is used to select which information to include in the status 
        
           type StatusSelection struct { 
        
           	// BasebackupInfo indicates whether to include basebackup information in the status 
        
           	BasebackupInfo bool 
        
           }

Opened a new issue #3121 for tracing it

github-actions · 2023-10-17T06:29:18Z

❗ By default, the pull request is configured to backport to all release branches.

To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

mnencia · 2023-10-17T09:57:15Z

@YanniHu1996 to fix the linter issues you should run golangci-lint run --fix

github-actions · 2023-10-19T07:26:54Z

❗ By default, the pull request is configured to backport to all release branches.

To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

github-actions · 2023-10-19T09:58:32Z

❗ By default, the pull request is configured to backport to all release branches.

To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

armru · 2023-10-23T11:48:53Z

pkg/management/postgres/probes.go

-		WHERE application_name LIKE $1 AND usename = $2`,
-		fmt.Sprintf("%s-%%", instance.ClusterName),
+		WHERE application_name ~ $1 AND usename = $2`,
+		fmt.Sprintf("%s-[0-9]+$", instance.ClusterName),


Personally I don't know if this changes should be in this patch

The change to this SQL is to filter out rows that are not represented as replication to standby instances, such as a wal sender with the application name <cluster-name-1-join> used by basebackup should not appear in the section Streaming Replication status for status command

leonardoce · 2023-10-23T18:45:56Z

/test limit=local

github-actions · 2023-10-23T18:46:09Z

@leonardoce, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/6617646214

pkg/management/postgres/probes.go

Signed-off-by: YanniHu1996 <yantian.hu@enterprisedb.com>

Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>

The reassig didn't produce any effects Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>

Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>

Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>

Signed-off-by: Tao Li <tao.li@enterprisedb.com>

leonardoce · 2023-10-24T09:22:31Z

/ok-to-merge

leonardoce · 2023-10-24T09:26:46Z

We've problems with the PRs opened from repositories other than cloudnative-pg/cloudnative-pg. The build containers step is failing. See #3154

`kubectl cnpg status` will now show information about the progress of backups taken with `pg_basebackup`, allowing monitoring the replica cloning process. Closes: #3011 Signed-off-by: YanniHu1996 <yantian.hu@enterprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com> Signed-off-by: Tao Li <tao.li@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com> Co-authored-by: Tao Li <tao.li@enterprisedb.com> (cherry picked from commit 2c29519)

github-actions bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.19 release-1.20 release-1.21 labels Oct 17, 2023

YanniHu1996 force-pushed the dev/cnp-4240 branch 9 times, most recently from 9fe4463 to b8d86c2 Compare October 19, 2023 07:25

YanniHu1996 closed this Oct 19, 2023

YanniHu1996 force-pushed the dev/cnp-4240 branch from b8d86c2 to c36aaf8 Compare October 19, 2023 07:26

YanniHu1996 reopened this Oct 19, 2023

YanniHu1996 force-pushed the dev/cnp-4240 branch from 12ca5df to 30f7585 Compare October 19, 2023 10:51

YanniHu1996 changed the title ~~fix: remove misleading rows in 'Streaming Replication status'~~ fix: enhance the plugin status command Oct 19, 2023

litaocdl force-pushed the dev/cnp-4240 branch from 30f7585 to af347f7 Compare October 19, 2023 11:57

YanniHu1996 mentioned this pull request Oct 19, 2023

optimize: reduce the run time of GetStatus #3121

Closed

YanniHu1996 marked this pull request as ready for review October 19, 2023 12:26

YanniHu1996 requested review from fcanovai, gbartolini, leonardoce, mnencia and phisco as code owners October 19, 2023 12:26

YanniHu1996 requested review from sxd and armru as code owners October 19, 2023 12:26

armru force-pushed the dev/cnp-4240 branch from af347f7 to d66f8b8 Compare October 23, 2023 11:27

armru changed the title ~~fix: enhance the plugin status command~~ feat: enhance the plugin status command Oct 23, 2023

armru reviewed Oct 23, 2023

View reviewed changes

armru approved these changes Oct 23, 2023

View reviewed changes

leonardoce force-pushed the dev/cnp-4240 branch 2 times, most recently from 616185b to f7b225e Compare October 23, 2023 18:45

litaocdl reviewed Oct 24, 2023

View reviewed changes

pkg/management/postgres/probes.go Outdated Show resolved Hide resolved

leonardoce approved these changes Oct 24, 2023

View reviewed changes

YanniHu1996 and others added 7 commits October 24, 2023 08:54

fix: enhance the 'plugin status' command

f5509d3

Signed-off-by: YanniHu1996 <yantian.hu@enterprisedb.com>

chore: review

6b72b31

Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>

chore: log error

361f3e6

The reassig didn't produce any effects Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>

refactor: always fetch backup data

96cc618

Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>

chore: review

a86e545

Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>

chore: review

b75e04b

Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>

review: log closeErr instead of err

8510b96

Signed-off-by: Tao Li <tao.li@enterprisedb.com>

leonardoce force-pushed the dev/cnp-4240 branch from 8858515 to 8510b96 Compare October 24, 2023 06:54

cnpg-bot added the ok to merge 👌 This PR can be merged label Oct 24, 2023

leonardoce merged commit 2c29519 into cloudnative-pg:main Oct 24, 2023
24 of 26 checks passed

leonardoce deleted the dev/cnp-4240 branch October 24, 2023 09:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: enhance the `plugin status` command #3101

feat: enhance the `plugin status` command #3101

YanniHu1996 commented Oct 17, 2023 •

edited

github-actions bot commented Oct 17, 2023

mnencia commented Oct 17, 2023

github-actions bot commented Oct 19, 2023

github-actions bot commented Oct 19, 2023

armru Oct 23, 2023

YanniHu1996 Oct 24, 2023 •

edited

leonardoce commented Oct 23, 2023

github-actions bot commented Oct 23, 2023

leonardoce commented Oct 24, 2023

leonardoce commented Oct 24, 2023

	// StatusOption is as a function to select which information to include in the status
	type StatusOption func(*StatusSelection)

	// StatusSelection is used to select which information to include in the status
	type StatusSelection struct {
	// BasebackupInfo indicates whether to include basebackup information in the status
	BasebackupInfo bool
	}

feat: enhance the plugin status command #3101

feat: enhance the plugin status command #3101

Conversation

YanniHu1996 commented Oct 17, 2023 • edited

github-actions bot commented Oct 17, 2023

mnencia commented Oct 17, 2023

github-actions bot commented Oct 19, 2023

github-actions bot commented Oct 19, 2023

armru Oct 23, 2023

Choose a reason for hiding this comment

YanniHu1996 Oct 24, 2023 • edited

Choose a reason for hiding this comment

leonardoce commented Oct 23, 2023

github-actions bot commented Oct 23, 2023

leonardoce commented Oct 24, 2023

leonardoce commented Oct 24, 2023

feat: enhance the `plugin status` command #3101

feat: enhance the `plugin status` command #3101

YanniHu1996 commented Oct 17, 2023 •

edited

YanniHu1996 Oct 24, 2023 •

edited