Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reduce fencing window for snapshot backups #3210

Merged
merged 6 commits into from
Oct 27, 2023
Merged

fix: reduce fencing window for snapshot backups #3210

merged 6 commits into from
Oct 27, 2023

Conversation

leonardoce
Copy link
Contributor

@leonardoce leonardoce commented Oct 26, 2023 •
edited by armru

Since VolumeSnapshots are consistent and the existence of a VolumeSnapshotContent object is enough to declare the snapshot cut, we're lifting fencing directly as soon as a VolumeSnapshotContent have been provisioned.

Closes: #3200

@github-actions github-actions bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.19 release-1.20 release-1.21 labels Oct 26, 2023
@github-actions
Copy link
Contributor

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@leonardoce leonardoce marked this pull request as ready for review October 27, 2023 06:27
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@leonardoce
Copy link
Contributor Author

I run manually the VolumeSnapshots E2e tests, and they're green.
Started a full E2e test run on the EDB repo: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/6664420143

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

3 similar comments
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

leonardoce and others added 6 commits October 27, 2023 17:04
@leonardoce @mnencia
fix: reduce fencing window for snapshot backups
efdf016 
Since VolumeSnapshots are consistent and the existence of a
VolumeSnapshotContent object is enough to declare the snapshot cut,
we're lifting fencing directly as soon as a VolumeSnapshotContent have
been provisioned.

Closes: #3200

Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
@leonardoce @mnencia
chore: refactoring
f90894a 
Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
@armru @mnencia
chore: check precodition first
7fe4c6d 
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
@armru @mnencia
chore: improve prepare snapshot logic
deaa5e4 
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
@armru @mnencia
chore: nits
3851a35 
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
@armru @mnencia
chore: improve todo
12cb10f 
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
@mnencia mnencia merged commit 245ebab into main Oct 27, 2023
19 of 20 checks passed
@mnencia mnencia deleted the dev/3200 branch October 27, 2023 15:05
cnpg-bot pushed a commit that referenced this pull request Oct 27, 2023
@leonardoce
fix: reduce fencing window for snapshot backups (#3210)
409de06 
Since VolumeSnapshots are consistent and the existence of a
VolumeSnapshotContent object is enough to declare the snapshot cut,
we're lifting fencing directly as soon as a VolumeSnapshotContent have
been provisioned.

Closes: #3200

Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
(cherry picked from commit 245ebab)
@github-actions github-actions bot mentioned this pull request Oct 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnencia mnencia mnencia approved these changes

@armru armru armru approved these changes

@fcanovai fcanovai Awaiting requested review from fcanovai

@gbartolini gbartolini Awaiting requested review from gbartolini

@phisco phisco Awaiting requested review from phisco

@sxd sxd Awaiting requested review from sxd

Assignees
No one assigned
Labels
backport-requested ◀️ This pull request should be backported to all supported releases release-1.19 release-1.20 release-1.21
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Reduce fencing windows with cold backups
3 participants
@leonardoce @mnencia @armru