Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add online and onlineConfiguration to ScheduledBackup #3226

Merged
merged 2 commits into from
Oct 27, 2023
Merged

feat: add online and onlineConfiguration to ScheduledBackup #3226

merged 2 commits into from
Oct 27, 2023

Conversation

armru
Copy link
Member

@armru armru commented Oct 27, 2023

This patch allows overriding the volume snapshot configuration specified inside the cluster with the one set in the ScheduledBackup object.

Closes #3166

@github-actions github-actions bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.19 release-1.20 release-1.21 labels Oct 27, 2023
@github-actions
Copy link
Contributor

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

@armru @leonardoce
feat: add online and onlineConfiguration to ScheduledBackup
8982d2a 
This patch allows overriding the volume snapshot configuration
specified inside the cluster with the one set in the ScheduledBackup
object.

Closes #3166

Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
@armru @leonardoce
doc: integrate
0a8c31e 
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
@leonardoce
Copy link
Contributor

/ok-to-merge

@cnpg-bot cnpg-bot added the ok to merge 👌 This PR can be merged label Oct 27, 2023
@leonardoce leonardoce merged commit 6f3739d into main Oct 27, 2023
33 of 34 checks passed
@leonardoce leonardoce deleted the dev/3166 branch October 27, 2023 13:20
cnpg-bot pushed a commit that referenced this pull request Oct 27, 2023
@armru
feat: add online and onlineConfiguration to ScheduledBackup (#3226)
22cb0db 
This patch allows overriding the volume snapshot configuration specified
inside the cluster with the one set in the ScheduledBackup object.

Closes #3166

Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
(cherry picked from commit 6f3739d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnencia mnencia mnencia approved these changes

@leonardoce leonardoce leonardoce approved these changes

@fcanovai fcanovai Awaiting requested review from fcanovai

@gbartolini gbartolini Awaiting requested review from gbartolini

@phisco phisco Awaiting requested review from phisco

@sxd sxd Awaiting requested review from sxd

Assignees
No one assigned
Labels
backport-requested ◀️ This pull request should be backported to all supported releases ok to merge 👌 This PR can be merged release-1.21
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: add online and onlineConfiguration to ScheduledBackup for volume snapshots
4 participants
@armru @leonardoce @mnencia @cnpg-bot