fix: add proper labels to the Pooler deployment
#3350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armru
requested review from
fcanovai,
gbartolini,
leonardoce,
mnencia,
phisco and
sxd
as code owners
armru
changed the title
Pooler deploymentPooler deployment
github-actions
bot
added
backport-requested ◀️
|
❗ By default, the pull request is configured to backport to all release branches.
|
armru
force-pushed
the
dev/add-label-to-pooler-deployment
branch
from
2d4e492
to
a5f0979
Compare
|
/test limit=local |
|
@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/6877861716 |
gabriele-wolfox
approved these changes
Nov 16, 2023
sxd
approved these changes
Nov 17, 2023
This patch ensures that we add the proper labels to the deployment. In a previous patch we ensured that the labels were present on the pods but not on the actual deployment. Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
sxd
force-pushed
the
dev/add-label-to-pooler-deployment
branch
from
a5f0979
to
cfb89d3
Compare
|
/ok-to-merge just a dangling test |
cnpg-bot
pushed a commit
that referenced
this pull request
Nov 17, 2023
This patch ensures that we add the proper labels to the deployment. In a previous patch we ensured that the labels were present on the pods but not on the actual deployment. Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit c295a7f)
cnpg-bot
pushed a commit
that referenced
this pull request
Nov 17, 2023
This patch ensures that we add the proper labels to the deployment. In a previous patch we ensured that the labels were present on the pods but not on the actual deployment. Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit c295a7f)
ceriath
pushed a commit
to ceriath/cloudnative-pg
that referenced
this pull request
Nov 23, 2023
This patch ensures that we add the proper labels to the deployment. In a previous patch we ensured that the labels were present on the pods but not on the actual deployment. Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch ensures that we add the proper labels to the deployment. In a previous patch we ensured that the labels were present on the pods but not on the actual deployment.