fix: reconcile Pooler RoleBinding
#3391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armru
requested review from
fcanovai,
gbartolini,
leonardoce,
mnencia,
phisco and
sxd
as code owners
github-actions
bot
added
backport-requested ◀️
|
❗ By default, the pull request is configured to backport to all release branches.
|
|
/test limit=local |
|
@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/6946313097 |
gbartolini
changed the title
Pooler RoleBindingPooler RoleBinding
YanniHu1996
approved these changes
Nov 23, 2023
litaocdl
force-pushed
the
dev/reconcile-pooler-rolebinding
branch
from
300ae5e
to
bf98c8e
Compare
|
/test limit=local |
|
@litaocdl, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/6975422629 |
litaocdl
approved these changes
Nov 24, 2023
mnencia
approved these changes
Nov 24, 2023
This patch ensures that we reconcile the rolebinding in case that we find differences. Previously we only executed the Creation. Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
litaocdl
force-pushed
the
dev/reconcile-pooler-rolebinding
branch
from
bf98c8e
to
c8ed9af
Compare
cnpg-bot
pushed a commit
that referenced
this pull request
Nov 24, 2023
This patch ensures that we reconcile the `RoleBinding` in case of differences. Previously, only the RoleBinding creation was executed. Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit c109128)
cnpg-bot
pushed a commit
that referenced
this pull request
Nov 24, 2023
This patch ensures that we reconcile the `RoleBinding` in case of differences. Previously, only the RoleBinding creation was executed. Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit c109128)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch ensures that we reconcile the
RoleBindingin case of differences.Previously, only the RoleBinding creation was executed.