Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: default Postgres SSL protocol version to TLSv1.3 #3408

Merged
merged 5 commits into from
Nov 28, 2023
Merged

feat: default Postgres SSL protocol version to TLSv1.3 #3408

merged 5 commits into from
Nov 28, 2023

Conversation

gbartolini
Copy link
Contributor

@gbartolini gbartolini commented Nov 24, 2023

Previously, CloudNativePG lacked the capability for users to configure specific TLS settings, relying on the default settings of PostgreSQL.

To address security and compliance concerns, CloudNativePG now sets the ssl_min_protocol_version and ssl_max_protocol_version GUCs to TLSv1.3 by default.

Additionally, users now have the flexibility to override these default options, along with the ssl_ciphers configuration.

Closes #3407
Closes #3376

@github-actions github-actions bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.20 release-1.21 labels Nov 24, 2023
Copy link
Contributor

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

@gbartolini gbartolini changed the title feat: set Postgres SSL protocol version to TLSv1.3 by default feat: default Postgres SSL protocol version to TLSv1.3 with CloudNativePG Nov 24, 2023
@gbartolini gbartolini changed the title feat: default Postgres SSL protocol version to TLSv1.3 with CloudNativePG feat: default Postgres SSL protocol version to TLSv1.3 Nov 24, 2023
Previously, CloudNativePG lacked the capability for users to configure specific
TLS settings, relying on the default settings of PostgreSQL.

To address security and compliance concerns, CloudNativePG now sets the
`ssl_min_protocol_version` and `ssl_max_protocol_version` GUCs to TLSv1.3 by
default.

Additionally, users now have the flexibility to override these default
options, along with the `ssl_ciphers` configuration.

Closes #3407
Closes #3376

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com>
@sxd
Copy link
Member

sxd commented Nov 27, 2023

/test depth=push test_level=4 feature_type=service-connectivity,replication

Copy link
Contributor

@sxd, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/7010018465

Copy link
Contributor

@sxd, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/7010087146

@sxd sxd added the do not merge 🙅 This PR cannot be merged (yet) label Nov 28, 2023
Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com>
@sxd
Copy link
Member

sxd commented Nov 28, 2023

/test depth=push test_level=4 feature_type=service-connectivity,replication

Copy link
Contributor

@sxd, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/7013922432

@sxd
Copy link
Member

sxd commented Nov 28, 2023

/test test_level=4 feature_type=service-connectivity,replication

Copy link
Contributor

@sxd, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/7013973399

@github-actions github-actions bot added the ok to merge 👌 This PR can be merged label Nov 28, 2023
… pg11

Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com>
@sxd sxd removed the do not merge 🙅 This PR cannot be merged (yet) label Nov 28, 2023
@sxd sxd merged commit 38ce92e into main Nov 28, 2023
33 checks passed
@sxd sxd deleted the dev/3407 branch November 28, 2023 15:21
cnpg-bot pushed a commit that referenced this pull request Nov 28, 2023
Previously, CloudNativePG lacked the capability for users to configure
specific TLS settings, relying on the default settings of PostgreSQL.

To address security and compliance concerns, CloudNativePG now sets the
`ssl_min_protocol_version` and `ssl_max_protocol_version` GUCs to
TLSv1.3 by default.

This default settings is only for Postgres >= 12, since version 11 doesn't
have support for these GUCs

Additionally, users now have the flexibility to override these default
options, along with the `ssl_ciphers` configuration.

Closes #3407
Closes #3376

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com>
Co-authored-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com>
(cherry picked from commit 38ce92e)
cnpg-bot pushed a commit that referenced this pull request Nov 28, 2023
Previously, CloudNativePG lacked the capability for users to configure
specific TLS settings, relying on the default settings of PostgreSQL.

To address security and compliance concerns, CloudNativePG now sets the
`ssl_min_protocol_version` and `ssl_max_protocol_version` GUCs to
TLSv1.3 by default.

This default settings is only for Postgres >= 12, since version 11 doesn't
have support for these GUCs

Additionally, users now have the flexibility to override these default
options, along with the `ssl_ciphers` configuration.

Closes #3407
Closes #3376

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com>
Co-authored-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com>
(cherry picked from commit 38ce92e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-requested ◀️ This pull request should be backported to all supported releases ok to merge 👌 This PR can be merged release-1.20 release-1.21
Projects
None yet
4 participants