fix: ensure Annotations and Labels are available #3434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YanniHu1996
requested review from
fcanovai,
gbartolini,
leonardoce,
mnencia,
phisco,
sxd and
armru
as code owners
github-actions
bot
added
backport-requested ◀️
|
❗ By default, the pull request is configured to backport to all release branches.
|
Signed-off-by: YanniHu1996 <yantian.hu@enterprisedb.com>
YanniHu1996
force-pushed
the
dev/cnp-4367
branch
from
1467b80
to
4593177
Compare
Signed-off-by: Tao Li <tao.li@enterprisedb.com>
litaocdl
approved these changes
Nov 30, 2023
|
/test limit=local |
|
@litaocdl, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/7043401066 |
armru
approved these changes
Nov 30, 2023
armru
reviewed
Nov 30, 2023
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
leonardoce
approved these changes
Nov 30, 2023
|
/ok-to-merge |
cnpg-bot
pushed a commit
that referenced
this pull request
Nov 30, 2023
Old versions of CNPG did not set any label or annotation on PodDisruptionBudgets. When upgrading to a newer version of CNPG, the metadata reconciliation of those PDBs failed, and this patch makes it working. Closes: #3435 Signed-off-by: YanniHu1996 <yantian.hu@enterprisedb.com> Signed-off-by: Tao Li <tao.li@enterprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Tao Li <tao.li@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit 86120ae)
litaocdl
added a commit
that referenced
this pull request
Dec 1, 2023
Old versions of CNPG did not set any label or annotation on PodDisruptionBudgets. When upgrading to a newer version of CNPG, the metadata reconciliation of those PDBs failed, and this patch makes it working. Closes: #3435 Signed-off-by: YanniHu1996 <yantian.hu@enterprisedb.com> Signed-off-by: Tao Li <tao.li@enterprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Tao Li <tao.li@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #3435