Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: evaluate 'immediate-checkpoint' and 'wait-for-archive' for backup command #3449

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

YanniHu1996
Copy link
Contributor

@YanniHu1996 YanniHu1996 commented Dec 1, 2023

Closes: #3431

…ommand

Signed-off-by: YanniHu1996 <yantian.hu@enterprisedb.com>
@github-actions github-actions bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.20 release-1.21 labels Dec 1, 2023
Copy link
Contributor

github-actions bot commented Dec 1, 2023

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

@litaocdl
Copy link
Collaborator

litaocdl commented Dec 1, 2023

/ok-to-merge

@cnpg-bot cnpg-bot added the ok to merge 👌 This PR can be merged label Dec 1, 2023
@litaocdl
Copy link
Collaborator

litaocdl commented Dec 1, 2023

/test ft=plugin limit=local

Copy link
Contributor

github-actions bot commented Dec 1, 2023

@litaocdl, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/7058108764

@litaocdl
Copy link
Collaborator

litaocdl commented Dec 2, 2023

/ok-to-merge

@litaocdl
Copy link
Collaborator

litaocdl commented Dec 2, 2023

Can we have a force merge for this pr, the required CI not pass is another issue, which not related with this one. opened ticket to track that.

@armru
Copy link
Member

armru commented Dec 4, 2023

/ok-to-merge

@armru armru changed the title fix: Apply 'immediate-checkpoint' and 'wait-for-archive' for backup command fix: evaluate 'immediate-checkpoint' and 'wait-for-archive' for backup command Dec 4, 2023
@mnencia mnencia merged commit 6aca8f8 into cloudnative-pg:main Dec 4, 2023
29 of 32 checks passed
@mnencia mnencia deleted the dev/cnp-4369 branch December 4, 2023 14:37
cnpg-bot pushed a commit that referenced this pull request Dec 4, 2023
…p command (#3449)

Closes: #3431

Signed-off-by: YanniHu1996 <yantian.hu@enterprisedb.com>
(cherry picked from commit 6aca8f8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-requested ◀️ This pull request should be backported to all supported releases ok to merge 👌 This PR can be merged release-1.20 release-1.21
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: cnpg backup with --immediate-checkpoint true ignored
6 participants