fix: correctly compare zero and nil .spec.projectedVolumeTemplate.sources
#3647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backport-requested ◀️
|
❗ By default, the pull request is configured to backport to all release branches.
|
YanniHu1996
requested review from
fcanovai,
gbartolini,
leonardoce,
mnencia,
phisco,
sxd and
armru
as code owners
YanniHu1996
force-pushed
the
dev/cnp-4428
branch
5 times, most recently
from
19aedc6
to
46b4544
Compare
litaocdl
force-pushed
the
dev/cnp-4428
branch
2 times, most recently
from
2ec964e
to
6109989
Compare
litaocdl
approved these changes
Jan 4, 2024
Signed-off-by: YanniHu1996 <yantian.hu@enterprisedb.com>
Signed-off-by: Tao Li <tao.li@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
|
/test limit=local |
|
@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/7421176887 |
armru
changed the title
ProjectedVolumeSource
armru
changed the title
ProjectedVolumeSourceProjectedVolumeTemplate sources
armru
changed the title
ProjectedVolumeTemplate sources.spec.projectedVolumeTemplate.sources
armru
changed the title
.spec.projectedVolumeTemplate.sources.spec.projectedVolumeTemplate.sources
armru
approved these changes
Jan 5, 2024
|
/ok-to-merge |
cnpg-bot
pushed a commit
that referenced
this pull request
Jan 5, 2024
…urces` (#3647) This patch prevents the rollout of the pod in case the current and expected `.spec.projectedVolumeTemplate.sources` use different semantics to describe a volume source not being present. Previously, we required a strict equivalence between the current and expected values of `.spec.projectedVolumeTemplate.sources`, which resulted in the operator initiating rollouts even when comparing zero and nil values. Closes: #3623 Signed-off-by: YanniHu1996 <yantian.hu@enterprisedb.com> Signed-off-by: Tao Li <tao.li@enterprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Tao Li <tao.li@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit e304898)
cnpg-bot
pushed a commit
that referenced
this pull request
Jan 5, 2024
…urces` (#3647) This patch prevents the rollout of the pod in case the current and expected `.spec.projectedVolumeTemplate.sources` use different semantics to describe a volume source not being present. Previously, we required a strict equivalence between the current and expected values of `.spec.projectedVolumeTemplate.sources`, which resulted in the operator initiating rollouts even when comparing zero and nil values. Closes: #3623 Signed-off-by: YanniHu1996 <yantian.hu@enterprisedb.com> Signed-off-by: Tao Li <tao.li@enterprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Tao Li <tao.li@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit e304898)
cnpg-bot
pushed a commit
that referenced
this pull request
Jan 5, 2024
…urces` (#3647) This patch prevents the rollout of the pod in case the current and expected `.spec.projectedVolumeTemplate.sources` use different semantics to describe a volume source not being present. Previously, we required a strict equivalence between the current and expected values of `.spec.projectedVolumeTemplate.sources`, which resulted in the operator initiating rollouts even when comparing zero and nil values. Closes: #3623 Signed-off-by: YanniHu1996 <yantian.hu@enterprisedb.com> Signed-off-by: Tao Li <tao.li@enterprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Tao Li <tao.li@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit e304898)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch prevents the rollout of the pod in case the current and expected
.spec.projectedVolumeTemplate.sourcesuse different semantics to describe a volume source not being present.Previously, we required a strict equivalence between the current and expected values of
.spec.projectedVolumeTemplate.sources, which resulted in the operator initiating rollouts even when comparing zero and nil values.Closes: #3623