fix: check recovery backups/snapshots readiness before cluster bootstrap #3663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YanniHu1996
requested review from
fcanovai,
gbartolini,
leonardoce,
mnencia,
phisco,
sxd and
armru
as code owners
github-actions
bot
added
backport-requested ◀️
|
❗ By default, the pull request is configured to backport to all release branches.
|
YanniHu1996
force-pushed
the
dev/cnp-4441
branch
4 times, most recently
from
10eb247
to
824219a
Compare
YanniHu1996
changed the title
litaocdl
force-pushed
the
dev/cnp-4441
branch
from
824219a
to
ec07c85
Compare
litaocdl
approved these changes
Jan 18, 2024
litaocdl
force-pushed
the
dev/cnp-4441
branch
from
a921f27
to
e1f8df8
Compare
jsilvela
reviewed
Jan 23, 2024
Comment on lines
+973
to
985
| cluster.Spec.Bootstrap.Recovery != nil { | ||
| var err error | ||
| backup, err = r.getOriginBackup(ctx, cluster) | ||
| if err != nil { | ||
| return ctrl.Result{}, err | ||
| } |
There was a problem hiding this comment.
this is already there before your PR, but the flow is very confusing.
We look for a backup object in the bootstrap.recovery, and it looks like we depend on it.
But further down we may still proceed if we had boostrap.recovery.volumesnapshots.
I'm going to try to make this more explicit.
jsilvela
force-pushed
the
dev/cnp-4441
branch
from
347697d
to
1095b94
Compare
jsilvela
approved these changes
Jan 25, 2024
|
/ok-to-merge |
jsilvela
changed the title
jsilvela
changed the title
jsilvela
force-pushed
the
dev/cnp-4441
branch
from
6048082
to
a5470cb
Compare
mnencia
force-pushed
the
dev/cnp-4441
branch
2 times, most recently
from
9013ae0
to
4133c13
Compare
YanniHu1996
force-pushed
the
dev/cnp-4441
branch
from
68c4d7b
to
dfdbeaa
Compare
Signed-off-by: YanniHu1996 <yantian.hu@enterprisedb.com>
…ots. Signed-off-by: YanniHu1996 <yantian.hu@enterprisedb.com>
Signed-off-by: YanniHu1996 <yantian.hu@enterprisedb.com>
Signed-off-by: Tao Li <tao.li@enterprisedb.com>
Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
mnencia
approved these changes
Mar 11, 2024
mnencia
changed the title
cnpg-bot
pushed a commit
that referenced
this pull request
Mar 11, 2024
…rap (#3663) Fix bootstrapping error loop by ensuring recovery backups/snapshots readiness before Cluster construction starts. This patch addresses an issue where Clusters bootstrapping from recovery could enter an error loop if the backups or snapshots were not prepared at the time of cluster creation. It modifies the bootstrapping process to delay the construction of the first instance until the necessary recovery backups or snapshots are fully ready, thus preventing the error loop. Closes #3654 Signed-off-by: YanniHu1996 <yantian.hu@enterprisedb.com> Signed-off-by: Tao Li <tao.li@enterprisedb.com> Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com> Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Co-authored-by: Tao Li <tao.li@enterprisedb.com> Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com> Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> (cherry picked from commit d7c7212)
mnencia
pushed a commit
that referenced
this pull request
Mar 11, 2024
…rap (#3663) Fix bootstrapping error loop by ensuring recovery backups/snapshots readiness before Cluster construction starts. This patch addresses an issue where Clusters bootstrapping from recovery could enter an error loop if the backups or snapshots were not prepared at the time of cluster creation. It modifies the bootstrapping process to delay the construction of the first instance until the necessary recovery backups or snapshots are fully ready, thus preventing the error loop. Closes #3654 Signed-off-by: YanniHu1996 <yantian.hu@enterprisedb.com> Signed-off-by: Tao Li <tao.li@enterprisedb.com> Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com> Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Co-authored-by: Tao Li <tao.li@enterprisedb.com> Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com> Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> (cherry picked from commit d7c7212)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bootstrapping error loop by ensuring recovery backups/snapshots
readiness before Cluster construction starts.
This patch addresses an issue where Clusters bootstrapping from
recovery could enter an error loop if the backups or snapshots were
not prepared at the time of cluster creation. It modifies the
bootstrapping process to delay the construction of the first instance
until the necessary recovery backups or snapshots are fully ready,
thus preventing the error loop.
Closes #3654