Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow configuration of certificate duration and expiring check time #3686

Merged

Conversation

zekiyeaydemir
Copy link
Contributor

@zekiyeaydemir zekiyeaydemir commented Jan 11, 2024

Allowed the configuration of certificationDuration and expiringCheckThreshold parameters.

Closes: #1691

Copy link
Contributor

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

@leonardoce leonardoce force-pushed the add-certificate-conf-zaydemir branch 5 times, most recently from e815a3a to a47c03c Compare January 11, 2024 14:52
@sxd sxd removed the release-1.20 label Feb 6, 2024
@leonardoce
Copy link
Contributor

Hi @zekiyeaydemir. We want to merge this in the next release.
Can you please test what happens when you set an incorrect value for CERTIFICATE_DURATION, for example, a string instead of a number? We need to be sure we'll have an understandable error message.
Thanks!

@sxd sxd self-assigned this Mar 11, 2024
@sxd sxd force-pushed the add-certificate-conf-zaydemir branch from a47c03c to b3432ad Compare March 11, 2024 14:31
zekiyeaydemir and others added 3 commits March 14, 2024 09:47
…eckThreshold parameters

Signed-off-by: Zekiye Aydemir <aydemirzekiye@gmail.com>
Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com>
@litaocdl litaocdl force-pushed the add-certificate-conf-zaydemir branch from 185b95b to c48634b Compare March 14, 2024 01:47
@litaocdl
Copy link
Collaborator

/test limit=local

@litaocdl
Copy link
Collaborator

/test limit=local d=push

Copy link
Contributor

@litaocdl, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/8274281348

Signed-off-by: Tao Li <tao.li@enterprisedb.com>
@litaocdl
Copy link
Collaborator

Hi @zekiyeaydemir. We want to merge this in the next release. Can you please test what happens when you set an incorrect value for CERTIFICATE_DURATION, for example, a string instead of a number? We need to be sure we'll have an understandable error message. Thanks!

if the invalid value is set for cetification duration or threhold, default will be used and info msg will reports in operator log

"Skipping invalid integer value parsing configuration","field":"CertificateDuration","value":"100s"

@litaocdl
Copy link
Collaborator

/ok-to-merge

@cnpg-bot cnpg-bot added the ok to merge 👌 This PR can be merged label Mar 14, 2024
Signed-off-by: Tao Li <tao.li@enterprisedb.com>
@litaocdl litaocdl merged commit 7963ee6 into cloudnative-pg:main Mar 14, 2024
25 checks passed
cnpg-bot pushed a commit that referenced this pull request Mar 14, 2024
…time (#3686)

This patch allowed the configuration of certificationDuration and
expiringCheckThreshold parameters in operator configmap.

Closes: #1691

Signed-off-by: Zekiye Aydemir <aydemirzekiye@gmail.com>
Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com>
Signed-off-by: Tao Li <tao.li@enterprisedb.com>
Co-authored-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Co-authored-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com>
Co-authored-by: Tao Li <tao.li@enterprisedb.com>
(cherry picked from commit 7963ee6)
cnpg-bot pushed a commit that referenced this pull request Mar 14, 2024
…time (#3686)

This patch allowed the configuration of certificationDuration and
expiringCheckThreshold parameters in operator configmap.

Closes: #1691

Signed-off-by: Zekiye Aydemir <aydemirzekiye@gmail.com>
Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com>
Signed-off-by: Tao Li <tao.li@enterprisedb.com>
Co-authored-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Co-authored-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com>
Co-authored-by: Tao Li <tao.li@enterprisedb.com>
(cherry picked from commit 7963ee6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-requested ◀️ This pull request should be backported to all supported releases ok to merge 👌 This PR can be merged release-1.21 release-1.22
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PG Certificates - configurable values for threshold \ certificateDuration
5 participants